Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Commit 044b73f

Browse files
authored
Merge pull request #13 from tnull/2023-07-pin-proc-macro2
Pin additional crates to fix MSRV builds in CI
2 parents e8413c0 + 949e49f commit 044b73f

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

.github/workflows/build.yml

+10-7
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,20 @@ jobs:
2525
toolchain: ${{ matrix.toolchain }}
2626
override: true
2727
profile: minimal
28-
- name: Pin tokio for MSRV
29-
if: matrix.msrv
30-
run: cargo update -p tokio --precise "1.14.1" --verbose
31-
- name: Pin serde for MSRV
28+
- name: Pin crates for MSRV
3229
if: matrix.msrv
3330
run: |
31+
# Tokio MSRV on versions 1.17 through 1.26 is rustc 1.49. Above 1.26 MSRV is 1.56.
32+
cargo update -p tokio --precise "1.14.1" --verbose
33+
# The serde_json crate switched to Rust edition 2021 starting with v1.0.101, i.e., has MSRV of 1.56
3434
cargo update -p serde_json --precise "1.0.99" --verbose
3535
cargo update -p serde --precise "1.0.156" --verbose
36-
- name: Pin log for MSRV
37-
if: matrix.msrv
38-
run: cargo update -p log --precise "0.4.18" --verbose
36+
# The quote crate switched to Rust edition 2021 starting with v1.0.31, i.e., has MSRV of 1.56
37+
cargo update -p quote --precise "1.0.30" --verbose
38+
# The proc-macro2 crate switched to Rust edition 2021 starting with v1.0.66, i.e., has MSRV of 1.56
39+
cargo update -p proc-macro2 --precise "1.0.65" --verbose
40+
# Sadly the log crate is always a dependency of tokio until 1.20, and has no reasonable MSRV guarantees
41+
cargo update -p log --precise "0.4.18" --verbose
3942
- name: Cargo check
4043
run: cargo check --release
4144
- name: Check documentation

0 commit comments

Comments
 (0)