Skip to content

Commit 042b62b

Browse files
committed
Fix several compile warnings when testing in no-std mode
1 parent 610511c commit 042b62b

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

lightning/src/routing/gossip.rs

+5-3
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ where C::Target: chain::Access, L::Target: Logger
197197
{
198198
network_graph: G,
199199
chain_access: Option<C>,
200+
#[cfg(feature = "std")]
200201
full_syncs_requested: AtomicUsize,
201202
pending_events: Mutex<Vec<MessageSendEvent>>,
202203
logger: L,
@@ -235,6 +236,7 @@ where C::Target: chain::Access, L::Target: Logger
235236
&self.network_graph
236237
}
237238

239+
#[cfg(feature = "std")]
238240
/// Returns true when a full routing table sync should be performed with a peer.
239241
fn should_request_full_sync(&self, _node_id: &PublicKey) -> bool {
240242
//TODO: Determine whether to request a full sync based on the network map.
@@ -421,13 +423,12 @@ where C::Target: chain::Access, L::Target: Logger
421423
// `gossip_timestamp_filter`, with the filter time set either two weeks ago or an hour ago.
422424
//
423425
// For no-std builds, we bury our head in the sand and do a full sync on each connection.
424-
let should_request_full_sync = self.should_request_full_sync(&their_node_id);
425426
#[allow(unused_mut, unused_assignments)]
426427
let mut gossip_start_time = 0;
427428
#[cfg(feature = "std")]
428429
{
429430
gossip_start_time = SystemTime::now().duration_since(UNIX_EPOCH).expect("Time must be > 1970").as_secs();
430-
if should_request_full_sync {
431+
if self.should_request_full_sync(&their_node_id) {
431432
gossip_start_time -= 60 * 60 * 24 * 7 * 2; // 2 weeks ago
432433
} else {
433434
gossip_start_time -= 60 * 60; // an hour ago
@@ -1862,7 +1863,7 @@ mod tests {
18621863
use ln::PaymentHash;
18631864
use ln::features::{ChannelFeatures, InitFeatures, NodeFeatures};
18641865
use routing::gossip::{P2PGossipSync, NetworkGraph, NetworkUpdate, NodeAlias, MAX_EXCESS_BYTES_FOR_RELAY, NodeId, RoutingFees, ChannelUpdateInfo, ChannelInfo, NodeAnnouncementInfo, NodeInfo};
1865-
use ln::msgs::{Init, RoutingMessageHandler, UnsignedNodeAnnouncement, NodeAnnouncement,
1866+
use ln::msgs::{RoutingMessageHandler, UnsignedNodeAnnouncement, NodeAnnouncement,
18661867
UnsignedChannelAnnouncement, ChannelAnnouncement, UnsignedChannelUpdate, ChannelUpdate,
18671868
ReplyChannelRange, QueryChannelRange, QueryShortChannelIds, MAX_VALUE_MSAT};
18681869
use util::test_utils;
@@ -2593,6 +2594,7 @@ mod tests {
25932594
#[cfg(feature = "std")]
25942595
fn calling_sync_routing_table() {
25952596
use std::time::{SystemTime, UNIX_EPOCH};
2597+
use ln::msgs::Init;
25962598

25972599
let network_graph = create_network_graph();
25982600
let (secp_ctx, gossip_sync) = create_gossip_sync(&network_graph);

lightning/src/util/test_utils.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -287,9 +287,9 @@ impl TestChannelMessageHandler {
287287

288288
impl Drop for TestChannelMessageHandler {
289289
fn drop(&mut self) {
290-
let l = self.expected_recv_msgs.lock().unwrap();
291290
#[cfg(feature = "std")]
292291
{
292+
let l = self.expected_recv_msgs.lock().unwrap();
293293
if !std::thread::panicking() {
294294
assert!(l.is_none() || l.as_ref().unwrap().is_empty());
295295
}
@@ -470,14 +470,12 @@ impl msgs::RoutingMessageHandler for TestRoutingMessageHandler {
470470
return ();
471471
}
472472

473-
let should_request_full_sync = self.request_full_sync.load(Ordering::Acquire);
474-
475473
#[allow(unused_mut, unused_assignments)]
476474
let mut gossip_start_time = 0;
477475
#[cfg(feature = "std")]
478476
{
479477
gossip_start_time = SystemTime::now().duration_since(UNIX_EPOCH).expect("Time must be > 1970").as_secs();
480-
if should_request_full_sync {
478+
if self.request_full_sync.load(Ordering::Acquire) {
481479
gossip_start_time -= 60 * 60 * 24 * 7 * 2; // 2 weeks ago
482480
} else {
483481
gossip_start_time -= 60 * 60; // an hour ago

lightning/src/util/wakers.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
1616
use alloc::sync::Arc;
1717
use core::mem;
18-
use core::time::Duration;
1918
use sync::{Condvar, Mutex};
2019

2120
use prelude::*;
2221

2322
#[cfg(any(test, feature = "std"))]
24-
use std::time::Instant;
23+
use std::time::{Duration, Instant};
2524

2625
use core::future::Future as StdFuture;
2726
use core::task::{Context, Poll};

0 commit comments

Comments
 (0)