Skip to content

Commit 0ac5697

Browse files
Bump MSRV to 1.30.0
We wanted to bump to 1.29 to continue to support mrustc bootstrapping, but on 1.29 there's a bug preventing us from compiling the lightning package only, thus parts of lightning-net-tokio cause a compilation error. The advantage of bumping the MSRV is an improved borrow checker which should enable improved code quality, and not having jump through weird hoops sometimes to get 1.22 working.
1 parent d0b4f52 commit 0ac5697

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ jobs:
88
matrix:
99
toolchain: [ stable,
1010
beta,
11-
# 1.22.0 is MSRV for rust-lightning in general:
12-
1.22.0,
11+
# 1.30.0 is MSRV for Rust-Lightning
12+
1.30.0,
1313
# 1.34.2 is Debian stable
1414
1.34.2,
1515
# 1.39.0 is MSRV for lightning-net-tokio and generates coverage

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ language: rust
22
rust:
33
- stable
44
- beta
5-
# 1.22.0 is MSRV for rust-lightning in general:
6-
- 1.22.0
5+
# 1.30.0 is MSRV for rust-lightning in general:
6+
- 1.30.0
77
# 1.34.2 is Debian stable
88
- 1.34.2
99
# 1.39.0 is MSRV for lightning-net-tokio and generates coverage

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ be covered by functional tests.
5050
When refactoring, structure your PR to make it easy to review and don't
5151
hestitate to split it into multiple small, focused PRs.
5252

53-
The Minimal Supported Rust Version is 1.22.0 (enforced by our Travis).
53+
The Minimal Supported Rust Version is 1.30.0 (enforced by our Travis and
54+
GitHub Actions).
5455

5556
Commits should cover both the issue fixed and the solution's rationale.
5657
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.

0 commit comments

Comments
 (0)