Skip to content

Commit 0ba12db

Browse files
committed
Clean up type aliases in functional_tests
In 3c3e93e we ran rustfmt blindly on `lightning/src/onion_message/functional_tests.rs`. This left the file with a handful of warts that really should have been cleaned up as we went. Here we clean up types a bit by importing structs directly and adding a few type aliases.
1 parent c7c3973 commit 0ba12db

File tree

1 file changed

+14
-23
lines changed

1 file changed

+14
-23
lines changed

lightning/src/onion_message/functional_tests.rs

Lines changed: 14 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ use crate::routing::test_utils::{add_channel, add_or_update_node};
3131
use crate::sign::{NodeSigner, Recipient};
3232
use crate::types::features::{ChannelFeatures, InitFeatures};
3333
use crate::util::ser::{FixedLengthReader, LengthReadable, Writeable, Writer};
34-
use crate::util::test_utils;
34+
use crate::util::test_utils::{TestChainSource, TestKeysInterface, TestLogger, TestNodeSigner};
3535

3636
use bitcoin::hex::FromHex;
3737
use bitcoin::network::Network;
@@ -45,35 +45,26 @@ use core::ops::Deref;
4545

4646
use crate::prelude::*;
4747

48+
type NetGraph = NetworkGraph<Arc<TestLogger>>;
49+
type MessageRouter = DefaultMessageRouter<Arc<NetGraph>, Arc<TestLogger>, Arc<TestKeysInterface>>;
50+
4851
struct MessengerNode {
4952
node_id: PublicKey,
5053
privkey: SecretKey,
51-
entropy_source: Arc<test_utils::TestKeysInterface>,
54+
entropy_source: Arc<TestKeysInterface>,
5255
messenger: OnionMessenger<
53-
Arc<test_utils::TestKeysInterface>,
54-
Arc<test_utils::TestNodeSigner>,
55-
Arc<test_utils::TestLogger>,
56+
Arc<TestKeysInterface>,
57+
Arc<TestNodeSigner>,
58+
Arc<TestLogger>,
5659
Arc<EmptyNodeIdLookUp>,
57-
Arc<
58-
DefaultMessageRouter<
59-
Arc<NetworkGraph<Arc<test_utils::TestLogger>>>,
60-
Arc<test_utils::TestLogger>,
61-
Arc<test_utils::TestKeysInterface>,
62-
>,
63-
>,
60+
Arc<MessageRouter>,
6461
Arc<TestOffersMessageHandler>,
6562
Arc<TestAsyncPaymentsMessageHandler>,
6663
Arc<TestDNSResolverMessageHandler>,
6764
Arc<TestCustomMessageHandler>,
6865
>,
6966
custom_message_handler: Arc<TestCustomMessageHandler>,
70-
gossip_sync: Arc<
71-
P2PGossipSync<
72-
Arc<NetworkGraph<Arc<test_utils::TestLogger>>>,
73-
Arc<test_utils::TestChainSource>,
74-
Arc<test_utils::TestLogger>,
75-
>,
76-
>,
67+
gossip_sync: Arc<P2PGossipSync<Arc<NetGraph>, Arc<TestChainSource>, Arc<TestLogger>>>,
7768
}
7869

7970
impl Drop for MessengerNode {
@@ -278,18 +269,18 @@ impl MessengerCfg {
278269
}
279270

280271
fn create_nodes_using_cfgs(cfgs: Vec<MessengerCfg>) -> Vec<MessengerNode> {
281-
let gossip_logger = Arc::new(test_utils::TestLogger::with_id("gossip".to_string()));
272+
let gossip_logger = Arc::new(TestLogger::with_id("gossip".to_string()));
282273
let network_graph = Arc::new(NetworkGraph::new(Network::Testnet, gossip_logger.clone()));
283274
let gossip_sync = Arc::new(P2PGossipSync::new(network_graph.clone(), None, gossip_logger));
284275

285276
let mut nodes = Vec::new();
286277
for (i, cfg) in cfgs.into_iter().enumerate() {
287278
let secret_key =
288279
cfg.secret_override.unwrap_or(SecretKey::from_slice(&[(i + 1) as u8; 32]).unwrap());
289-
let logger = Arc::new(test_utils::TestLogger::with_id(format!("node {}", i)));
280+
let logger = Arc::new(TestLogger::with_id(format!("node {}", i)));
290281
let seed = [i as u8; 32];
291-
let entropy_source = Arc::new(test_utils::TestKeysInterface::new(&seed, Network::Testnet));
292-
let node_signer = Arc::new(test_utils::TestNodeSigner::new(secret_key));
282+
let entropy_source = Arc::new(TestKeysInterface::new(&seed, Network::Testnet));
283+
let node_signer = Arc::new(TestNodeSigner::new(secret_key));
293284

294285
let node_id_lookup = Arc::new(EmptyNodeIdLookUp {});
295286
let message_router =

0 commit comments

Comments
 (0)