Expose onion message module as public

And fix some warnings

Author: valentinewallace

lightning/src/lib.rs

@@ -76,8 +76,7 @@ pub mod util;
 pub mod chain;
 pub mod ln;
 pub mod routing;
-#[allow(unused)]
-mod onion_message; // To be exposed after sending/receiving OMs is supported in PeerManager.
+pub mod onion_message;
 
 #[cfg(feature = "std")]
 /// Re-export of either `core2::io` or `std::io`, depending on the `std` feature flag.

lightning/src/onion_message/blinded_route.rs

@@ -16,7 +16,6 @@ use super::utils;
 use util::chacha20poly1305rfc::ChaChaPolyWriteAdapter;
 use util::ser::{VecWriter, Writeable, Writer};
 
-use core::iter::FromIterator;
 use io;
 use prelude::*;
 

lightning/src/onion_message/messenger.rs

@@ -35,9 +35,7 @@ use prelude::*;
 ///
 /// # Example
 ///
-//  Needs to be `ignore` until the `onion_message` module is made public, otherwise this is a test
-//  failure.
-/// ```ignore
+/// ```
 /// # extern crate bitcoin;
 /// # use bitcoin::hashes::_export::_core::time::Duration;
 /// # use bitcoin::secp256k1::{PublicKey, Secp256k1, SecretKey};

lightning/src/onion_message/packet.rs

@@ -74,7 +74,7 @@ impl LengthReadable for Packet {
 		while read_idx < hop_data_len {
 			let mut read_buffer = [0; READ_BUFFER_SIZE];
 			let read_amt = cmp::min(hop_data_len - read_idx, READ_BUFFER_SIZE);
-			r.read_exact(&mut read_buffer[..read_amt]);
+			r.read_exact(&mut read_buffer[..read_amt])?;
 			hop_data.extend_from_slice(&read_buffer[..read_amt]);
 			read_idx += read_amt;
 		}