tests: Add sanity tests for ChannelOpens

Author: dongcarl

src/ln/functional_tests.rs

@@ -47,6 +47,45 @@ use rand::{thread_rng, Rng};
 
 use ln::functional_test_utils::*;
 
+#[test]
+fn test_insane_channel_opens() {
+	let nodes = create_network(2, &[None, None]);
+
+	nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 100000000, 42).unwrap();
+
+	let open_channel_message = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
+
+	let insane_open_helper = |expected_error_str, message_mutator: fn(msgs::OpenChannel) -> msgs::OpenChannel| {
+		match &nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), LocalFeatures::new(), &message_mutator(open_channel_message.clone())) {
+			Err(msgs::HandleError{ err: expected_error_str, action: Some(msgs::ErrorAction::SendErrorMessage {..})}) => {},
+			Err(msgs::HandleError{ err: _, action: Some(msgs::ErrorAction::SendErrorMessage {..})}) => {panic!("unexpected HandleError string")},
+			Err(_) => { panic!("unexpected Err")}
+			_ => panic!("insane OpenChannel message was somehow Ok"),
+		}
+	};
+
+	use ln::channel::MAX_FUNDING_SATOSHIS;
+	use ln::channelmanager::MAX_LOCAL_BREAKDOWN_TIMEOUT;
+
+	insane_open_helper("funding value > 2^24", |mut msg| { msg.funding_satoshis = MAX_FUNDING_SATOSHIS; msg });
+
+	insane_open_helper("Bogus channel_reserve_satoshis", |mut msg| { msg.channel_reserve_satoshis = msg.funding_satoshis + 1; msg });
+
+	insane_open_helper("push_msat larger than funding value", |mut msg| { msg.push_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 + 1; msg });
+
+	insane_open_helper("Peer never wants payout outputs?", |mut msg| { msg.dust_limit_satoshis = msg.funding_satoshis + 1 ; msg });
+
+	insane_open_helper("Bogus; channel reserve is less than dust limit", |mut msg| { msg.dust_limit_satoshis = msg.channel_reserve_satoshis + 1; msg });
+
+	insane_open_helper("Minimum htlc value is full channel value", |mut msg| { msg.htlc_minimum_msat = (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000; msg });
+
+	insane_open_helper("They wanted our payments to be delayed by a needlessly long period", |mut msg| { msg.to_self_delay = MAX_LOCAL_BREAKDOWN_TIMEOUT + 1; msg });
+
+	insane_open_helper("0 max_accpted_htlcs makes for a useless channel", |mut msg| { msg.max_accepted_htlcs = 0; msg });
+
+	insane_open_helper("max_accpted_htlcs > 483", |mut msg| { msg.max_accepted_htlcs = 484; msg });
+}
+
 #[test]
 fn test_async_inbound_update_fee() {
 	let mut nodes = create_network(2, &[None, None]);