PeerMan: fix bug in drop_gossip util

valentinewallace · valentinewallace · commit 1de698fdd927 · 2022-08-25T14:56:50.000-04:00
Fixes a flipped bool that was introduced in 4a1ee5f
diff --git a/lightning/src/ln/peer_handler.rs b/lightning/src/ln/peer_handler.rs
@@ -399,11 +399,8 @@ impl Peer {
 
 	/// Returns whether this peer's buffer is full and we should drop gossip messages.
 	fn buffer_full_drop_gossip(&self) -> bool {
-		if self.pending_outbound_buffer.len() > OUTBOUND_BUFFER_LIMIT_DROP_GOSSIP
-			|| self.msgs_sent_since_pong > BUFFER_DRAIN_MSGS_PER_TICK * FORWARD_INIT_SYNC_BUFFER_LIMIT_RATIO {
-				return false
-		}
-		true
+		self.pending_outbound_buffer.len() > OUTBOUND_BUFFER_LIMIT_DROP_GOSSIP ||
+			self.msgs_sent_since_pong > BUFFER_DRAIN_MSGS_PER_TICK * FORWARD_INIT_SYNC_BUFFER_LIMIT_RATIO
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -399,11 +399,8 @@ impl Peer {`
`399`	`399`
`400`	`400`	`/// Returns whether this peer's buffer is full and we should drop gossip messages.`
`401`	`401`	`fn buffer_full_drop_gossip(&self) -> bool {`
`402`		`- if self.pending_outbound_buffer.len() > OUTBOUND_BUFFER_LIMIT_DROP_GOSSIP`
`403`		`- \|\| self.msgs_sent_since_pong > BUFFER_DRAIN_MSGS_PER_TICK * FORWARD_INIT_SYNC_BUFFER_LIMIT_RATIO {`
`404`		`- return false`
`405`		`- }`
`406`		`- true`
	`402`	`+ self.pending_outbound_buffer.len() > OUTBOUND_BUFFER_LIMIT_DROP_GOSSIP \|\|`
	`403`	`+ self.msgs_sent_since_pong > BUFFER_DRAIN_MSGS_PER_TICK * FORWARD_INIT_SYNC_BUFFER_LIMIT_RATIO`
`407`	`404`	`}`
`408`	`405`	`}`
`409`	`406`