Skip to content

Commit 22e9709

Browse files
committed
Export Onion Message structs in their respective modules
Re-exports in Rust make `use` statements a little shorter, but for otherwise don't materially change a crate's API. Sadly, the C bindings generator currently can't figure out re-exports, but it also exports everything into one global namespace, so it doesn't matter much anyway.
1 parent bf84742 commit 22e9709

File tree

6 files changed

+13
-15
lines changed

6 files changed

+13
-15
lines changed

fuzz/src/onion_message.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use lightning::ln::script::ShutdownScript;
1111
use lightning::util::enforcing_trait_impls::EnforcingSigner;
1212
use lightning::util::logger::Logger;
1313
use lightning::util::ser::{Readable, Writer};
14-
use lightning::onion_message::OnionMessenger;
14+
use lightning::onion_message::messenger::OnionMessenger;
1515

1616
use utils::test_logger;
1717

lightning/src/ln/msgs.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ pub struct UpdateAddHTLC {
311311
pub struct OnionMessage {
312312
/// Used in decrypting the onion packet's payload.
313313
pub blinding_point: PublicKey,
314-
pub(crate) onion_routing_packet: onion_message::Packet,
314+
pub(crate) onion_routing_packet: onion_message::packet::Packet,
315315
}
316316

317317
/// An update_fulfill_htlc message to be sent or received from a peer
@@ -1404,7 +1404,7 @@ impl Readable for OnionMessage {
14041404
let blinding_point: PublicKey = Readable::read(r)?;
14051405
let len: u16 = Readable::read(r)?;
14061406
let mut packet_reader = FixedLengthReader::new(r, len as u64);
1407-
let onion_routing_packet: onion_message::Packet = <onion_message::Packet as LengthReadable>::read(&mut packet_reader)?;
1407+
let onion_routing_packet = <onion_message::packet::Packet as LengthReadable>::read(&mut packet_reader)?;
14081408
Ok(Self {
14091409
blinding_point,
14101410
onion_routing_packet,

lightning/src/ln/peer_handler.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use util::ser::{VecWriter, Writeable, Writer};
2525
use ln::peer_channel_encryptor::{PeerChannelEncryptor,NextNoiseStep};
2626
use ln::wire;
2727
use ln::wire::Encode;
28-
use onion_message::{SimpleArcOnionMessenger, SimpleRefOnionMessenger};
28+
use onion_message::messenger::{SimpleArcOnionMessenger, SimpleRefOnionMessenger};
2929
use routing::gossip::{NetworkGraph, P2PGossipSync};
3030
use util::atomic_counter::AtomicCounter;
3131
use util::crypto::sign;

lightning/src/onion_message/functional_tests.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
use chain::keysinterface::{KeysInterface, Recipient};
1313
use ln::features::InitFeatures;
1414
use ln::msgs::{self, OnionMessageHandler};
15-
use super::{BlindedRoute, Destination, OnionMessenger, SendError};
15+
use super::blinded_route::BlindedRoute;
16+
use super::messenger::{Destination, OnionMessenger, SendError};
1617
use util::enforcing_trait_impls::EnforcingSigner;
1718
use util::test_utils;
1819

lightning/src/onion_message/messenger.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ use prelude::*;
4141
/// # use bitcoin::hashes::_export::_core::time::Duration;
4242
/// # use bitcoin::secp256k1::{PublicKey, Secp256k1, SecretKey};
4343
/// # use lightning::chain::keysinterface::{InMemorySigner, KeysManager, KeysInterface};
44-
/// # use lightning::onion_message::{BlindedRoute, Destination, OnionMessenger};
44+
/// # use lightning::onion_message::messenger::{Destination, OnionMessenger};
45+
/// # use lightning::onion_message::blinded_route::BlindedRoute;
4546
/// # use lightning::util::logger::{Logger, Record};
4647
/// # use std::sync::Arc;
4748
/// # struct FakeLogger {};

lightning/src/onion_message/mod.rs

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,12 @@
1818
//! information on its usage.
1919
//!
2020
//! [offers]: <https://github.com/lightning/bolts/pull/798>
21-
//! [blinded routes]: crate::onion_message::BlindedRoute
21+
//! [blinded routes]: crate::onion_message::blinded_route::BlindedRoute
22+
//! [`OnionMessenger`]: crate::onion_message::messenger::OnionMessenger
2223
23-
mod blinded_route;
24-
mod messenger;
25-
mod packet;
24+
pub mod blinded_route;
25+
pub mod messenger;
26+
pub mod packet;
2627
mod utils;
2728
#[cfg(test)]
2829
mod functional_tests;
29-
30-
// Re-export structs so they can be imported with just the `onion_message::` module prefix.
31-
pub use self::blinded_route::{BlindedRoute, BlindedHop};
32-
pub use self::messenger::{Destination, OnionMessenger, SendError, SimpleArcOnionMessenger, SimpleRefOnionMessenger};
33-
pub(crate) use self::packet::Packet;

0 commit comments

Comments
 (0)