Create separate timer for scorer persistence in background processor

Author: arik-so

lightning-background-processor/src/lib.rs

@@ -79,6 +79,11 @@ const PING_TIMER: u64 = 1;
 /// Prune the network graph of stale entries hourly.
 const NETWORK_PRUNE_TIMER: u64 = 60 * 60;
 
+#[cfg(all(not(test), debug_assertions))]
+const SCORER_PERSIST_TIMER: u64 = 30;
+#[cfg(test)]
+const SCORER_PERSIST_TIMER: u64 = 1;
+
 #[cfg(not(test))]
 const FIRST_NETWORK_PRUNE_TIMER: u64 = 60;
 #[cfg(test)]
@@ -214,6 +219,7 @@ impl BackgroundProcessor {
 			let mut last_freshness_call = Instant::now();
 			let mut last_ping_call = Instant::now();
 			let mut last_prune_call = Instant::now();
+			let mut last_scorer_persist_call = Instant::now();
 			let mut have_pruned = false;
 
 			loop {
@@ -286,10 +292,9 @@ impl BackgroundProcessor {
 						log_trace!(logger, "Assessing prunability of network graph");
 
 						// The network graph must not be pruned while rapid sync completion is pending
-						let should_prune = if let Some(rapid_sync) = rapid_gossip_sync.as_ref() {
-							rapid_sync.is_initial_sync_complete()
-						} else {
-							true
+						let should_prune = match rapid_gossip_sync.as_ref(){
+							Some(rapid_sync) => { rapid_sync.is_initial_sync_complete() }
+							None => { true }
 						};
 
 						if should_prune {
@@ -306,12 +311,16 @@ impl BackgroundProcessor {
 							log_trace!(logger, "Not pruning network graph due to pending gossip sync");
 						}
 					}
+				}
+
+				if last_scorer_persist_call.elapsed().as_secs() > SCORER_PERSIST_TIMER {
 					if let Some(ref scorer) = scorer {
 						log_trace!(logger, "Persisting scorer");
 						if let Err(e) = persister.persist_scorer(&scorer) {
 							log_error!(logger, "Error: Failed to persist scorer, check your disk and permissions {}", e)
 						}
 					}
+					last_scorer_persist_call = Instant::now();
 				}
 			}