f Fix configurable in-flight limit percentage 2

Author: ViktorTigerstrom

lightning/src/ln/channel.rs

@@ -746,8 +746,10 @@ pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
 pub const ANCHOR_OUTPUT_VALUE_SATOSHI: u64 = 330;
 
 /// The percentage of the channel value `holder_max_htlc_value_in_flight_msat` used to be set to,
-/// before this was made configurable.
-pub const OLD_LDK_MAX_IN_FLIGHT_PERCENT: u8 = 10;
+/// before this was made configurable. The percentage was made configurable in LDK 0.0.107,
+/// although LDK 0.0.104+ enabled serialization of channels with a different value set for
+/// `holder_max_htlc_value_in_flight_msat`.
+pub const MAX_IN_FLIGHT_PERCENT_LEGACY: u8 = 10;
 
 /// Maximum `funding_satoshis` value according to the BOLT #2 specification, if
 /// `option_support_large_channel` (aka wumbo channels) is not supported.
@@ -808,13 +810,12 @@ macro_rules! secp_check {
 
 impl<Signer: Sign> Channel<Signer> {
 	/// Returns the value to use for `holder_max_htlc_value_in_flight_msat` as a percentage of the
-	/// `channel_value_satoshis` in msat, based on how many of the percent its been configured to
-	/// be set to by the user.
+	/// `channel_value_satoshis` in msat, set through
+	/// [`ChannelHandkshakeConfig::max_inbound_htlc_value_in_flight_percent_of_channel`]
 	///
-	/// As we only allow the user to set the percentage to a value between `1-100`, if the user
-	/// sets a value less than `1`, the function will result in `1` percent of the
-	/// `channel_value_satoshis`, as well as `100` percent if the user has set a value larger
-	/// than `100`.
+	/// The effective percentage is lower bounded by 1% and upper bounded by 100%.
+	///
+	/// [`ChannelHandkshakeConfig::max_inbound_htlc_value_in_flight_percent_of_channel`]: crate::util::config::ChannelHandshakeConfig::max_inbound_htlc_value_in_flight_percent_of_channel
 	fn get_holder_max_htlc_value_in_flight_msat(channel_value_satoshis: u64, config: &ChannelHandshakeConfig) -> u64 {
 		let configured_percent = if config.max_inbound_htlc_value_in_flight_percent_of_channel < 1 {
 			1
@@ -5904,7 +5905,7 @@ impl<Signer: Sign> Writeable for Channel<Signer> {
 			{ Some(self.holder_selected_channel_reserve_satoshis) } else { None };
 
 		let mut old_max_in_flight_percent_config = UserConfig::default().own_channel_config;
-		old_max_in_flight_percent_config.max_inbound_htlc_value_in_flight_percent_of_channel = OLD_LDK_MAX_IN_FLIGHT_PERCENT;
+		old_max_in_flight_percent_config.max_inbound_htlc_value_in_flight_percent_of_channel = MAX_IN_FLIGHT_PERCENT_LEGACY;
 		let serialized_holder_htlc_max_in_flight =
 			if self.holder_max_htlc_value_in_flight_msat != Self::get_holder_max_htlc_value_in_flight_msat(self.channel_value_satoshis, &old_max_in_flight_percent_config)
 			{ Some(self.holder_max_htlc_value_in_flight_msat) } else { None };