Add test for insufficient liquidity

Added `test_insufficient_liquidity_for_bolt12_offer` 
to verify error handling when there's insufficient liquidity
when calling `pay_for_offer`.  

Also updated `fails_creating_invoice_request_without_blinded_reply_path` 
and `fails_creating_or_paying_for_offer_without_connected_peers` tests
because after disconnecting peers, channel liquidity drops to 0. So the
expected error  should be `InsufficientLiquidity` instead of
`MissingPaths`

Author: slanesuke

lightning/src/ln/channelmanager.rs

@@ -64,7 +64,7 @@ use crate::ln::wire::Encode;
 use crate::offers::invoice::{BlindedPayInfo, Bolt12Invoice, DEFAULT_RELATIVE_EXPIRY, DerivedSigningPubkey, ExplicitSigningPubkey, InvoiceBuilder, UnsignedBolt12Invoice};
 use crate::offers::invoice_error::InvoiceError;
 use crate::offers::invoice_request::{DerivedPayerId, InvoiceRequestBuilder};
-use crate::offers::offer::{Offer, OfferBuilder, Amount};
+use crate::offers::offer::{Amount, Offer, OfferBuilder};
 use crate::offers::parse::Bolt12SemanticError;
 use crate::offers::refund::{Refund, RefundBuilder};
 use crate::onion_message::async_payments::{AsyncPaymentsMessage, HeldHtlcAvailable, ReleaseHeldHtlc, AsyncPaymentsMessageHandler};

lightning/src/ln/offers_tests.rs

@@ -1275,7 +1275,7 @@ fn fails_creating_or_paying_for_offer_without_connected_peers() {
 
 	match david.node.pay_for_offer(&offer, None, None, None, payment_id, Retry::Attempts(0), None) {
 		Ok(_) => panic!("Expected error"),
-		Err(e) => assert_eq!(e, Bolt12SemanticError::MissingPaths),
+		Err(e) => assert_eq!(e, Bolt12SemanticError::InsufficientLiquidity),
 	}
 
 	assert!(nodes[0].node.list_recent_payments().is_empty());
@@ -1438,7 +1438,7 @@ fn fails_creating_invoice_request_without_blinded_reply_path() {
 
 	match david.node.pay_for_offer(&offer, None, None, None, payment_id, Retry::Attempts(0), None) {
 		Ok(_) => panic!("Expected error"),
-		Err(e) => assert_eq!(e, Bolt12SemanticError::MissingPaths),
+		Err(e) => assert_eq!(e, Bolt12SemanticError::InsufficientLiquidity),
 	}
 
 	assert!(nodes[0].node.list_recent_payments().is_empty());
@@ -1724,3 +1724,34 @@ fn fails_paying_invoice_more_than_once() {
 	let invoice_error = extract_invoice_error(alice, &onion_message);
 	assert_eq!(invoice_error, InvoiceError::from_string("DuplicateInvoice".to_string()));
 }
+
+#[test]
+fn test_insufficient_liquidity_for_bolt12_offer() {
+	let channel_mon_config = create_chanmon_cfgs(2);
+	let node_config = create_node_cfgs(2, &channel_mon_config);
+	let node_chanmgrs = create_node_chanmgrs(2, &node_config, &[None, None]);
+	let nodes = create_network(2, &node_config, &node_chanmgrs);
+
+	create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 1_000_000_000);
+
+	let (alice, bob) = (&nodes[0], &nodes[1]);
+	let alice_id = alice.node.get_our_node_id();
+
+	let offer = alice.node
+		.create_offer_builder(None).unwrap()
+		.clear_paths()
+		.amount_msats(1_000_000_001)
+		.build().unwrap();
+	assert_eq!(offer.signing_pubkey(), Some(alice_id));
+	assert!(offer.paths().is_empty());
+
+	let payment_id = PaymentId([1; 32]);
+
+	let result = bob.node.pay_for_offer(&offer, None, None, None, payment_id, Retry::Attempts(0), None);
+	match result {
+		Ok(_) => panic!("Expected error with insufficient liquidity."),
+		Err(e) => {
+			assert_eq!(e, Bolt12SemanticError::InsufficientLiquidity);
+		}
+	}
+}