Skip to content

Commit 531ade7

Browse files
committed
Handle splice_locked message
1 parent 7e22541 commit 531ade7

File tree

2 files changed

+87
-3
lines changed

2 files changed

+87
-3
lines changed

lightning/src/ln/channel.rs

+35
Original file line numberDiff line numberDiff line change
@@ -9003,6 +9003,41 @@ impl<SP: Deref> FundedChannel<SP> where
90039003
Ok(())
90049004
}
90059005

9006+
#[cfg(splicing)]
9007+
pub fn splice_locked<NS: Deref, L: Deref>(
9008+
&mut self, msg: &msgs::SpliceLocked, node_signer: &NS, chain_hash: ChainHash,
9009+
user_config: &UserConfig, best_block: &BestBlock, logger: &L,
9010+
) -> Result<Option<msgs::AnnouncementSignatures>, ChannelError>
9011+
where
9012+
NS::Target: NodeSigner,
9013+
L::Target: Logger
9014+
{
9015+
let pending_splice = match self.pending_splice.as_mut() {
9016+
Some(pending_splice) => pending_splice,
9017+
None => {
9018+
return Err(ChannelError::Warn(format!("Channel is not in pending splice")));
9019+
},
9020+
};
9021+
9022+
if let Some(sent_funding_txid) = pending_splice.sent_funding_txid {
9023+
if sent_funding_txid == msg.splice_txid {
9024+
if let Some(funding) = self.pending_funding
9025+
.iter_mut()
9026+
.find(|funding| funding.get_funding_txo().map(|txo| txo.txid) == Some(sent_funding_txid))
9027+
{
9028+
promote_splice_funding!(self, funding);
9029+
return Ok(self.get_announcement_sigs(node_signer, chain_hash, user_config, best_block.height, logger));
9030+
}
9031+
9032+
// TODO: Close channel?
9033+
return Ok(None);
9034+
}
9035+
}
9036+
9037+
pending_splice.received_funding_txid = Some(msg.splice_txid);
9038+
Ok(None)
9039+
}
9040+
90069041
// Send stuff to our remote peers:
90079042

90089043
/// Queues up an outbound HTLC to send by placing it in the holding cell. You should call

lightning/src/ln/channelmanager.rs

+52-3
Original file line numberDiff line numberDiff line change
@@ -9610,6 +9610,48 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
96109610
Err(MsgHandleErrInternal::send_err_msg_no_close("TODO(splicing): Splicing is not implemented (splice_ack)".to_owned(), msg.channel_id))
96119611
}
96129612

9613+
#[cfg(splicing)]
9614+
fn internal_splice_locked(&self, counterparty_node_id: &PublicKey, msg: &msgs::SpliceLocked) -> Result<(), MsgHandleErrInternal> {
9615+
let per_peer_state = self.per_peer_state.read().unwrap();
9616+
let peer_state_mutex = per_peer_state.get(counterparty_node_id)
9617+
.ok_or_else(|| {
9618+
debug_assert!(false);
9619+
MsgHandleErrInternal::send_err_msg_no_close(format!("Can't find a peer matching the passed counterparty node_id {}", counterparty_node_id), msg.channel_id)
9620+
})?;
9621+
let mut peer_state_lock = peer_state_mutex.lock().unwrap();
9622+
let peer_state = &mut *peer_state_lock;
9623+
9624+
// Look for the channel
9625+
match peer_state.channel_by_id.entry(msg.channel_id) {
9626+
hash_map::Entry::Vacant(_) => return Err(MsgHandleErrInternal::send_err_msg_no_close(format!(
9627+
"Got a message for a channel from the wrong node! No such channel for the passed counterparty_node_id {}",
9628+
counterparty_node_id
9629+
), msg.channel_id)),
9630+
hash_map::Entry::Occupied(mut chan_entry) => {
9631+
if let Some(chan) = chan_entry.get_mut().as_funded_mut() {
9632+
let logger = WithChannelContext::from(&self.logger, &chan.context, None);
9633+
let announcement_sigs_opt = try_channel_entry!(
9634+
self, peer_state, chan.splice_locked(
9635+
msg, &self.node_signer, self.chain_hash, &self.default_configuration,
9636+
&self.best_block.read().unwrap(), &&logger,
9637+
), chan_entry
9638+
);
9639+
if let Some(announcement_sigs) = announcement_sigs_opt {
9640+
log_trace!(logger, "Sending announcement_signatures for channel {}", chan.context.channel_id());
9641+
peer_state.pending_msg_events.push(MessageSendEvent::SendAnnouncementSignatures {
9642+
node_id: counterparty_node_id.clone(),
9643+
msg: announcement_sigs,
9644+
});
9645+
}
9646+
} else {
9647+
return Err(MsgHandleErrInternal::send_err_msg_no_close("Channel is not funded, cannot splice".to_owned(), msg.channel_id));
9648+
}
9649+
},
9650+
};
9651+
9652+
Err(MsgHandleErrInternal::send_err_msg_no_close("TODO(splicing): Splicing is not implemented (splice_locked)".to_owned(), msg.channel_id))
9653+
}
9654+
96139655
/// Process pending events from the [`chain::Watch`], returning whether any events were processed.
96149656
fn process_pending_monitor_events(&self) -> bool {
96159657
debug_assert!(self.total_consistency_lock.try_write().is_err()); // Caller holds read lock
@@ -12123,9 +12165,16 @@ where
1212312165

1212412166
#[cfg(splicing)]
1212512167
fn handle_splice_locked(&self, counterparty_node_id: PublicKey, msg: &msgs::SpliceLocked) {
12126-
let _: Result<(), _> = handle_error!(self, Err(MsgHandleErrInternal::send_err_msg_no_close(
12127-
"Splicing not supported (splice_locked)".to_owned(),
12128-
msg.channel_id)), counterparty_node_id);
12168+
let _persistence_guard = PersistenceNotifierGuard::optionally_notify(self, || {
12169+
let res = self.internal_splice_locked(&counterparty_node_id, msg);
12170+
let persist = match &res {
12171+
Err(e) if e.closes_channel() => NotifyOption::DoPersist,
12172+
Err(_) => NotifyOption::SkipPersistHandleEvents,
12173+
Ok(()) => NotifyOption::SkipPersistHandleEvents,
12174+
};
12175+
let _ = handle_error!(self, res, counterparty_node_id);
12176+
persist
12177+
});
1212912178
}
1213012179

1213112180
fn handle_shutdown(&self, counterparty_node_id: PublicKey, msg: &msgs::Shutdown) {

0 commit comments

Comments
 (0)