f ?

Author: TheBlueMatt

lightning/src/routing/scoring.rs

@@ -443,9 +443,21 @@ struct HistoricalBucketRangeTracker {
 impl HistoricalBucketRangeTracker {
 	fn new() -> Self { Self { buckets: [0; 8] } }
 	fn track_datapoint(&mut self, bucket: u8) {
+		// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
+		// we spend in each bucket as a fixed-point number with 5 bits for the fractional part.
+		//
+		// Each time we update our liquidity estimate, we add 32 to the buckets for the current
+		// min and max liquidity offset positions.
+		//
+		// We then decay each bucket by multiplying by 2047/2048. This ensures we can't actually
+		// reach 65,535 - when we get to 63,457 adding 32 and decaying by 2047/2048 leaves us back
+		// at 63,457.
+		//
+		// In total, this allows us to track data for the last 8,000 or so payments across a given
+		// channel.
 		debug_assert!(bucket < 8);
 		if let Some(v) = self.buckets.get_mut(bucket as usize) {
-			*v = v.saturating_add(8);
+			*v = v.saturating_add(32);
 			for e in self.buckets.iter_mut() {
 				*e = ((*e as u64) * 2047 / 2048) as u16;
 			}
@@ -791,18 +803,6 @@ impl<L: DerefMut<Target = u64>, BRT: DerefMut<Target = HistoricalBucketRangeTrac
 	}
 
 	fn update_history_buckets(&mut self) {
-		// We have 8 leaky buckets for min and max liquidity. Each bucket tracks the amount of time
-		// we spend in each bucket as a fixed-point number with 5 bits for the fractional part.
-		//
-		// Each time we update our liquidity estimate, we add 32 to the buckets for the current
-		// min and max liquidity offset positions.
-		//
-		// We then decay each bucket by multiplying by 2047/2048. This ensures we can't actually
-		// reach 65,535 - when we get to 63,457 adding 32 and decaying by 2047/2048 leaves us back
-		// at 63,457.
-		//
-		// In total, this allows us to track data for the last 8,000 or so payments across a given
-		// channel.
 		debug_assert!(*self.min_liquidity_offset_msat <= self.capacity_msat);
 		self.min_liquidity_offset_history.track_datapoint(
 			(self.min_liquidity_offset_msat.saturating_sub(1) * 8 / self.capacity_msat)