Skip to content

Commit 6ca6f18

Browse files
committed
Reduce log severity of onion failures and log CLN bug 5154.
1 parent 031e46e commit 6ca6f18

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lightning/src/ln/onion_utils.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,8 @@ pub(super) fn process_onion_failure<T: secp256k1::Signing, L: Deref>(secp_ctx: &
434434
// short channel id.
435435
if failing_route_hop.short_channel_id == chan_update.contents.short_channel_id {
436436
short_channel_id = Some(failing_route_hop.short_channel_id);
437+
} else {
438+
log_info!(logger, "Node provided a channel_update for which it was not authoritative, likely a busted CLN node - https://github.com/ElementsProject/lightning/issues/5154");
437439
}
438440
network_update = Some(NetworkUpdate::ChannelUpdateMessage {
439441
msg: chan_update,
@@ -478,10 +480,10 @@ pub(super) fn process_onion_failure<T: secp256k1::Signing, L: Deref>(secp_ctx: &
478480

479481
let (description, title) = errors::get_onion_error_description(error_code);
480482
if debug_field_size > 0 && err_packet.failuremsg.len() >= 4 + debug_field_size {
481-
log_warn!(logger, "Onion Error[from {}: {}({:#x}) {}({})] {}", route_hop.pubkey, title, error_code, debug_field, log_bytes!(&err_packet.failuremsg[4..4+debug_field_size]), description);
483+
log_info!(logger, "Onion Error[from {}: {}({:#x}) {}({})] {}", route_hop.pubkey, title, error_code, debug_field, log_bytes!(&err_packet.failuremsg[4..4+debug_field_size]), description);
482484
}
483485
else {
484-
log_warn!(logger, "Onion Error[from {}: {}({:#x})] {}", route_hop.pubkey, title, error_code, description);
486+
log_info!(logger, "Onion Error[from {}: {}({:#x})] {}", route_hop.pubkey, title, error_code, description);
485487
}
486488
} else {
487489
// Useless packet that we can't use but it passed HMAC, so it

0 commit comments

Comments
 (0)