f ugh lol wtf

Author: TheBlueMatt

lightning/src/debug_sync.rs

@@ -145,15 +145,17 @@ impl<T> Mutex<T> {
 
 	pub fn try_lock<'a>(&'a self) -> LockResult<MutexGuard<'a, T>> {
 		let res = self.inner.try_lock().map(|lock| MutexGuard { mutex: self, lock }).map_err(|_| ());
-		MUTEXES_HELD.with(|held| {
-			// Since a try-lock will simply fail if the lock is held already, we do not
-			// consider try-locks to ever generate lockorder inversions. However, if a try-lock
-			// succeeds, we do consider it to have created lockorder dependencies.
-			for locked in held.borrow().iter() {
-				self.deps.locked_before.lock().unwrap().insert(Arc::clone(locked));
-			}
-			held.borrow_mut().insert(Arc::clone(&self.deps));
-		});
+		if res.is_ok() {
+			MUTEXES_HELD.with(|held| {
+				// Since a try-lock will simply fail if the lock is held already, we do not
+				// consider try-locks to ever generate lockorder inversions. However, if a try-lock
+				// succeeds, we do consider it to have created lockorder dependencies.
+				for locked in held.borrow().iter() {
+					self.deps.locked_before.lock().unwrap().insert(Arc::clone(locked));
+				}
+				held.borrow_mut().insert(Arc::clone(&self.deps));
+			});
+		}
 		res
 	}
 }