-f Add debug_assert in untractable paths

Author: Antoine Riard

lightning/src/chain/onchain_utils.rs

@@ -202,6 +202,9 @@ impl PackageSolvingData {
 		let amt = match self {
 			PackageSolvingData::RevokedOutput(ref outp) => { outp.amount },
 			PackageSolvingData::CounterpartyHTLCOutput(ref outp) => { outp.htlc.amount_msat / 1000 },
+			// Note: Currently, amounts of holder outputs spending witnesses aren't used
+			// as we can't malleate spending package to increase their feerate. This
+			// should change with the remaining anchor output patchset.
 			PackageSolvingData::HolderHTLCOutput(..) => { 0 },
 			PackageSolvingData::HolderFundingOutput(..) => { 0 },
 		};
@@ -214,8 +217,8 @@ impl PackageSolvingData {
 			// Note: Currently, weights of holder outputs spending witnesses aren't used
 			// as we can't malleate spending package to increase their feerate. This
 			// should change with the remaining anchor output patchset.
-			PackageSolvingData::HolderHTLCOutput(..) => { 0 },
-			PackageSolvingData::HolderFundingOutput(..) => { 0 },
+			PackageSolvingData::HolderHTLCOutput(..) => { debug_assert!(false); 0 },
+			PackageSolvingData::HolderFundingOutput(..) => { debug_assert!(false); 0 },
 		};
 		weight
 	}

lightning/src/chain/onchaintx.rs

@@ -346,6 +346,10 @@ impl<ChannelSigner: Sign> OnchainTxHandler<ChannelSigner> {
 				return Some((new_timer, new_feerate, transaction))
 			}
 		} else {
+			// Note: Currently, amounts of holder outputs spending witnesses aren't used
+			// as we can't malleate spending package to increase their feerate. This
+			// should change with the remaining anchor output patchset.
+			debug_assert!(amt == 0);
 			if let Some(transaction) = cached_request.finalize_package(self, amt, self.destination_script.clone(), logger) {
 				return Some((None, 0, transaction));
 			}