Skip to content

Commit 7e8969d

Browse files
committed
f some feedback
1 parent 9b5809b commit 7e8969d

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

CHANGELOG.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,25 @@
44
* Support for relaying onion messages has been added via a new
55
`OnionMessenger` struct when passed as the `OnionMessageHandler` to a
66
`PeerManager`. Pre-encoded onion messages can also be sent and received
7-
(#1503, #1640, #1650, #1652, #1688).
7+
(#1503, #1650, #1652, #1688).
88
* Rate-limiting of outbound gossip syncs has been rewritten to utilize less
99
buffering inside LDK. The new rate-limiting is also used for onion messages
1010
to avoid delaying other messages (#1604. #1660, #1683).
1111
* Rather than spawning a full OS thread, `lightning-background-processor` has
1212
a new `process_events_async` method which takes the place of a
13-
`BackgroundProcessor` for those using Rust async (#1657).
13+
`BackgroundProcessor` for those using Rust's async (#1657).
1414
* The `Filter::register_output` return value has been removed, as it was
15-
very difficult to correctly implemented (i.e. without blocking) (#1663).
15+
very difficult to correctly implement (i.e., without blocking). Users
16+
previously using it should instead pass dependent transactions in via new
17+
`chain::Confirm::transactions_confirmed` calls (#1663).
1618
* `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
1719
been added to allow configuring counterparty reserve values (#1619).
1820
* The `rust-bitcoin` dependency has been updated 0.29 (#1658).
1921
* The `bitcoin_hashes` dependency has been updated 0.11 (#1677).
2022
* `ChannelManager::broadcast_node_announcement` has been moved to
2123
`PeerManager` (#1699).
2224
* `{Init,Node}Features` sent to peers/broadcasted are now fetched via the
23-
various `*MessageHandler` traits, rather than hard-coded (#1701, XXX OMs).
25+
various `*MessageHandler` traits, rather than hard-coded (#1701, #1688).
2426
* `Event::PaymentPathFailed::rejected_by_dest` has been renamed
2527
`payment_failed_permanently` (#1702).
2628
* `Invoice` now derives the std `Hash` trait (#1575).
@@ -38,10 +40,10 @@
3840
output via a new `Balance::CounterpartyRevokedOutputClaimable` (#1495).
3941
* Inbound HTLCs for which we do not (yet) have a preimage are now included in
4042
`get_claimable_balance` via a `Balance::MaybePreimageClaimableHTLC` (#1673).
41-
* Probes which fail prior to being sent over their first hop are correctly
43+
* Probes that fail prior to being sent over their first hop are correctly
4244
failed with a `Event::ProbeFailed` rather than a `PaymentPathFailed` (#1704).
4345
* Pending `Event::HTLCHandlingFailed`s are no longer lost on restart (#1700).
44-
* HTLCs which fail prior to being sent over their first hop are now marked as
46+
* HTLCs that fail prior to being sent over their first hop are now marked as
4547
retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
4648
* Dust HTLCs are now considered failed in the payment tracking logic after the
4749
commitment transaction confirms, allowing retry on restart (#1691).

0 commit comments

Comments
 (0)