Skip to content

Commit 807af19

Browse files
committed
Abort if insufficient liquidity in pay_for_offer
This commit introduces a check to abort early if there's insufficient liquidity when fulfilling the payment in `pay_for_offer` f liquidity check for offer-based amount
1 parent 6e73c37 commit 807af19

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

lightning/src/ln/channelmanager.rs

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ use crate::ln::wire::Encode;
6464
use crate::offers::invoice::{BlindedPayInfo, Bolt12Invoice, DEFAULT_RELATIVE_EXPIRY, DerivedSigningPubkey, ExplicitSigningPubkey, InvoiceBuilder, UnsignedBolt12Invoice};
6565
use crate::offers::invoice_error::InvoiceError;
6666
use crate::offers::invoice_request::{DerivedPayerId, InvoiceRequestBuilder};
67-
use crate::offers::offer::{Offer, OfferBuilder};
67+
use crate::offers::offer::{Offer, OfferBuilder, Amount};
6868
use crate::offers::parse::Bolt12SemanticError;
6969
use crate::offers::refund::{Refund, RefundBuilder};
7070
use crate::onion_message::async_payments::{AsyncPaymentsMessage, HeldHtlcAvailable, ReleaseHeldHtlc, AsyncPaymentsMessageHandler};
@@ -8818,6 +8818,22 @@ where
88188818
};
88198819
let invoice_request = builder.build_and_sign()?;
88208820

8821+
let total_liquidity: u64 = self.list_usable_channels().iter().map(|channel| channel.next_outbound_htlc_limit_msat).sum();
8822+
let total_amount_msats = match invoice_request.amount_msats() {
8823+
Some(amount_msats) => Some(amount_msats),
8824+
None => match offer.amount() {
8825+
Some(Amount::Bitcoin { amount_msats }) => Some(amount_msats),
8826+
_ => None,
8827+
},
8828+
};
8829+
8830+
if let Some(amount) = total_amount_msats {
8831+
if amount > total_liquidity {
8832+
log_error!(self.logger, "Insufficient liquidity for payment with payment id: {}", payment_id);
8833+
return Err(Bolt12SemanticError::InsufficientLiquidity);
8834+
}
8835+
}
8836+
88218837
let context = OffersContext::OutboundPayment { payment_id };
88228838
let reply_path = self.create_blinded_path(context).map_err(|_| Bolt12SemanticError::MissingPaths)?;
88238839

lightning/src/offers/parse.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ pub enum Bolt12SemanticError {
193193
UnexpectedPaymentHash,
194194
/// A signature was expected but was missing.
195195
MissingSignature,
196+
/// There is insufficient liquidity to complete the payment.
197+
InsufficientLiquidity,
196198
}
197199

198200
impl From<bech32::Error> for Bolt12ParseError {

0 commit comments

Comments
 (0)