f explicitly prevent scid alias of 0

Author: TheBlueMatt

lightning/src/ln/channelmanager.rs

@@ -1816,7 +1816,9 @@ impl<Signer: Sign, M: Deref, T: Deref, K: Deref, F: Deref, L: Deref> ChannelMana
 			} else {
 				outbound_scid_alias = fake_scid::Namespace::OutboundAlias.get_fake_scid(height, &self.genesis_hash, &self.fake_scid_rand_bytes, &self.keys_manager);
 			}
-			if self.outbound_scid_aliases.lock().unwrap().insert(outbound_scid_alias) { break; }
+			if outbound_scid_alias != 0 && self.outbound_scid_aliases.lock().unwrap().insert(outbound_scid_alias) {
+				break;
+			}
 			i += 1;
 			if i > 1_000_000 { panic!("Your RNG is busted or we ran out of possible outbound SCID aliases (which should never happen before we run out of memory to store channels"); }
 		}