|
10 | 10 | `MessageSendEvent::PaymentFailureNetworkUpdate` but instead included in a
|
11 | 11 | new field in the `Event::PaymentFailed` events. Generally, this means route
|
12 | 12 | graph updates are no longer handled as a part of the `PeerManager` but
|
13 |
| - instead through the new `EventHandler` implementation of |
| 13 | + instead through the new `EventHandler` implementation for |
14 | 14 | `NetGraphMsgHandler`. To make this easy, a new parameter to
|
15 | 15 | `lightning-background-processor::BackgroundProcessor::start` is added, which
|
16 | 16 | contains an `Option`al `NetGraphmsgHandler`. If provided as `Some`, relevant
|
17 | 17 | events will be processed by the `NetGraphMsgHandler` prior to normal event
|
18 | 18 | handling (#1043).
|
19 | 19 | * `NetworkGraph` is now, itself, thread-safe. Accordingly, most functions now
|
20 | 20 | take `&self` instead of `&mut self` and the graph data can be accessed
|
21 |
| - through `NetworkGraph.read_only()` (#1043). |
| 21 | + through `NetworkGraph.read_only` (#1043). |
22 | 22 | * The balances available on-chain to claim after a channel has been closed are
|
23 | 23 | now exposed via `ChannelMonitor::get_claimable_balances` and
|
24 | 24 | `ChainMonitor::get_claimable_balances`. The second can be used to get
|
25 | 25 | information about all closed channels which still have on-chain balances
|
26 | 26 | associated with them. See enum variants of `ln::channelmonitor::Balance` and
|
27 | 27 | method documentation for the above methods for more information on the types
|
28 | 28 | of balances exposed (#1034).
|
29 |
| - * When one HTLC out of several as a part of a multi-path payment fails, the |
30 |
| - new field `all_paths_failed` in `Event::PaymentFailed` is set to `false`. |
31 |
| - This implies that the payment has not failed, but only one part. Payment |
32 |
| - resolution is only indicated by an `Event::PaymentSent` event or an |
33 |
| - `Event::PaymentFailed` with `all_paths_failed` set to `true`, which is also |
34 |
| - set for the last remaining part of a multi-path payment (#1053). |
| 29 | + * When one HTLC of a multi-path payment fails, the new field `all_paths_failed` |
| 30 | + in `Event::PaymentFailed` is set to `false`. This implies that the payment |
| 31 | + has not failed, but only one part. Payment resolution is only indicated by an |
| 32 | + `Event::PaymentSent` event or an `Event::PaymentFailed` with |
| 33 | + `all_paths_failed` set to `true`, which is also set for the last remaining |
| 34 | + part of a multi-path payment (#1053). |
35 | 35 | * To better capture the context described above, `Event::PaymentFailed` has
|
36 | 36 | been renamed to `Event::PaymentPathFailed` (#1084).
|
37 |
| - * A new event, `ChannelClosed` is provided by `ChannelManager` when a channel |
| 37 | + * A new event, `ChannelClosed`, is provided by `ChannelManager` when a channel |
38 | 38 | is closed, including a reason and error message (if relevant, #997).
|
39 | 39 | * `lightning-invoice` now considers invoices with sub-millisatoshi precision
|
40 | 40 | to be invalid, and requires millisatoshi values during construction (thus
|
|
50 | 50 |
|
51 | 51 | ## Bug Fixes
|
52 | 52 | * Fix a panic when reading a lightning invoice with a non-recoverable
|
53 |
| - signature. Further, restrict lightning invoice parsing require payment |
| 53 | + signature. Further, restrict lightning invoice parsing to require payment |
54 | 54 | secrets and better handle a few edge cases as required by BOLT 11 (#1057).
|
55 | 55 | * Fix a panic when receiving multiple messages (such as HTLC fulfill messages)
|
56 | 56 | after a call to `chain::Watch::update_channel` returned
|
|
73 | 73 | deserialized objects in 0.100. Such `Event`s will lead to an
|
74 | 74 | `Err(DecodeError::InvalidValue)` in versions prior to 0.0.100. The only such
|
75 | 75 | new event written by 0.0.101 is `Event::ChannelClosed` (#1087).
|
76 |
| - * Payments which were initiated in versions prior to 0.0.101 may still |
| 76 | + * Payments that were initiated in versions prior to 0.0.101 may still |
77 | 77 | generate duplicate `PaymentSent` `Event`s or may have spurious values for
|
78 | 78 | `Event::PaymentPathFailed::all_paths_failed` (#1053).
|
79 | 79 | * The return values of `ChannelMonitor::get_claimable_balances` (and, thus,
|
80 | 80 | `ChainMonitor::get_claimable_balances`) may be spurious for channels where
|
81 | 81 | the spend of the funding transaction appeared on chain while running a
|
82 | 82 | version prior to 0.0.101. `Balance` information should only be relied upon
|
83 |
| - for channels which were closed while running 0.0.101+ (#1034). |
| 83 | + for channels that were closed while running 0.0.101+ (#1034). |
84 | 84 | * Payments failed while running versions prior to 0.0.101 will never have a
|
85 | 85 | `Some` for the `network_update` field (#1043).
|
86 | 86 |
|
|
0 commit comments