f use lambda for check

Author: TheBlueMatt

lightning/src/routing/scoring.rs

@@ -825,16 +825,19 @@ impl<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>,
 			let required_decays = self.now.duration_since(*self.last_updated).as_secs()
 				.checked_div(params.historical_no_updates_half_life.as_secs())
 				.map_or(u32::max_value(), |decays| cmp::min(decays, u32::max_value() as u64) as u32);
+
 			// Rather than actually decaying the individual buckets, which would lose precision, we
 			// simply track whether all buckets would be decayed to zero, in which case we treat it
 			// as if we had no data.
-			// there are none, treat it as if we had no data.
 			let mut is_fully_decayed = true;
+			let mut check_track_bucket_contains_undecayed_points =
+				|bucket_val: u16| if bucket_val.checked_shr(required_decays).unwrap_or(0) > 0 { is_fully_decayed = false; };
+
 			for (min_idx, min_bucket) in self.min_liquidity_offset_history.buckets.iter().enumerate() {
-				if min_bucket.checked_shr(required_decays).unwrap_or(0) > 0 { is_fully_decayed = false; }
+				check_track_bucket_contains_undecayed_points(*min_bucket);
 				for max_bucket in self.max_liquidity_offset_history.buckets.iter().take(8 - min_idx) {
 					total_valid_points_tracked += (*min_bucket as u64) * (*max_bucket as u64);
-					if max_bucket.checked_shr(required_decays).unwrap_or(0) > 0 { is_fully_decayed = false; }
+					check_track_bucket_contains_undecayed_points(*max_bucket);
 				}
 			}
 			// If the total valid points is smaller than 1.0 (i.e. 32 in our fixed-point scheme),