f accept more connections than we do channels

Author: TheBlueMatt

lightning/src/ln/channelmanager.rs

@@ -934,6 +934,10 @@ const MAX_UNFUNDED_CHANS_PER_PEER: usize = 4;
 /// this many peers we reject new (inbound) channels.
 const MAX_UNFUNDED_CHANNEL_PEERS: usize = 50;
 
+/// The maximum number of peers which we do not have a (funded) channel with. Once we reach this
+/// many peers we reject new (inbound) connections.
+const MAX_NO_CHANNEL_PEERS: usize = 250;
+
 /// Information needed for constructing an invoice route hint for this channel.
 #[derive(Clone, Debug, PartialEq)]
 pub struct CounterpartyForwardingInfo {
@@ -6295,7 +6299,7 @@ where
 				}
 				node.is_connected
 			});
-		if inbound && !this_peer_has_funded_channels && connected_peers_without_funded_channels >= MAX_UNFUNDED_CHANNEL_PEERS {
+		if inbound && !this_peer_has_funded_channels && connected_peers_without_funded_channels >= MAX_NO_CHANNEL_PEERS {
 			return Err(());
 		}
 
@@ -8556,10 +8560,10 @@ mod tests {
 		// Now nodes[0] is disconnected but still has a pending, un-funded channel lying around.
 		// Even though we accept one more connection from new peers, we won't actually let them
 		// open channels.
-		assert_eq!(peer_pks.len(), super::MAX_NO_CHANNEL_PEERS - 1);
-		for peer_pk in peer_pks {
-			nodes[1].node.handle_open_channel(&peer_pk, &open_channel_msg);
-			get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, peer_pk);
+		assert!(peer_pks.len() > super::MAX_UNFUNDED_CHANNEL_PEERS - 1);
+		for i in 0..super::MAX_UNFUNDED_CHANNEL_PEERS - 1 {
+			nodes[1].node.handle_open_channel(&peer_pks[i], &open_channel_msg);
+			get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, peer_pks[i]);
 			open_channel_msg.temporary_channel_id = nodes[0].keys_manager.get_secure_random_bytes();
 		}
 		nodes[1].node.handle_open_channel(&last_random_pk, &open_channel_msg);