Skip to content

Commit b2d71ed

Browse files
committed
Use a smaller bit for UnknownFeature
When testing Bolt12Invoice unknown require feature handling, a large feature bit can cause SendError::TooBigPacket when creating an onion message. Use a smaller feature bit for UnknownFeature, which also has the added benefit of reducing test output.
1 parent f9ebc4c commit b2d71ed

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lightning/src/ln/features.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ mod sealed {
436436
// Note: update the module-level docs when a new feature bit is added!
437437

438438
#[cfg(test)]
439-
define_feature!(123456789, UnknownFeature,
439+
define_feature!(12345, UnknownFeature,
440440
[NodeContext, ChannelContext, Bolt11InvoiceContext, OfferContext, InvoiceRequestContext, Bolt12InvoiceContext, BlindedHopContext],
441441
"Feature flags for an unknown feature used in testing.", set_unknown_feature_optional,
442442
set_unknown_feature_required, supports_unknown_test_feature, requires_unknown_test_feature);
@@ -1064,7 +1064,7 @@ mod tests {
10641064
features.set_unknown_feature_required();
10651065
assert!(features.requires_unknown_bits());
10661066
assert!(features.supports_unknown_bits());
1067-
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![123456788]);
1067+
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![12344]);
10681068

10691069
let mut features = ChannelFeatures::empty();
10701070
features.set_unknown_feature_optional();
@@ -1074,14 +1074,14 @@ mod tests {
10741074

10751075
let mut features = ChannelFeatures::empty();
10761076
features.set_unknown_feature_required();
1077-
features.set_custom_bit(123456786).unwrap();
1077+
features.set_custom_bit(12346).unwrap();
10781078
assert!(features.requires_unknown_bits());
10791079
assert!(features.supports_unknown_bits());
1080-
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![123456786, 123456788]);
1080+
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![12344, 12346]);
10811081

10821082
let mut limiter = ChannelFeatures::empty();
10831083
limiter.set_unknown_feature_optional();
1084-
assert_eq!(features.required_unknown_bits_from(&limiter), vec![123456786]);
1084+
assert_eq!(features.required_unknown_bits_from(&limiter), vec![12346]);
10851085
}
10861086

10871087
#[test]

0 commit comments

Comments
 (0)