Expose script building gated with a new feature flag

Author: devrandom

lightning/Cargo.toml

@@ -12,6 +12,8 @@ Still missing tons of error-handling. See GitHub issues for suggested projects i
 
 [features]
 fuzztarget = ["bitcoin/fuzztarget"]
+test_utils = []
+# Internal test utilities exposed to other repo crates
 _test_utils = ["hex", "regex"]
 # Unlog messages superior at targeted level.
 max_level_off = []

lightning/src/ln/chan_utils.rs

@@ -910,7 +910,7 @@ impl CommitmentTransaction {
 		}
 	}
 
-	#[cfg(feature = "_test_utils")]
+	#[cfg(feature = "test_utils")]
 	/// Get the transaction output scripts.
 	///
 	/// For debugging purposes, since only the hash is present in the actual transaction.
@@ -1007,17 +1007,17 @@ impl CommitmentTransaction {
 		});
 
 		let mut outputs = Vec::with_capacity(txouts.len());
-		#[cfg(feature = "_test_utils")]
+		#[cfg(feature = "test_utils")]
 		let mut scripts = Vec::new();
-		#[cfg(not(feature = "_test_utils"))]
+		#[cfg(not(feature = "test_utils"))]
 		let scripts = Vec::new();
 		for (idx, out) in txouts.drain(..).enumerate() {
 			if let Some(htlc) = (out.1).1 {
 				htlc.transaction_output_index = Some(idx as u32);
 				htlcs.push(htlc.clone());
 			}
 			outputs.push(out.0);
-			#[cfg(feature = "_test_utils")]
+			#[cfg(feature = "test_utils")]
 			scripts.push((out.1).0);
 		}
 		Ok((outputs, htlcs, scripts))