Make routing benchmark robust against path changes

If the scoring in the routing benchmark causes us to take a
different path from the original scan, we may end up deciding that
the only path to a node has a too-high total CLTV delta, causing us
to panic in the benchmarking phase.

Here we simply check for that possibility and remove paths that
fail post-scoring.

Author: TheBlueMatt

lightning/src/routing/router.rs

@@ -5433,7 +5433,7 @@ mod benches {
 		let mut routes = Vec::new();
 		let mut route_endpoints = Vec::new();
 		let mut seed: usize = 0xdeadbeef;
-		'load_endpoints: for _ in 0..100 {
+		'load_endpoints: for _ in 0..150 {
 			loop {
 				seed *= 0xdeadbeef;
 				let src = PublicKey::from_slice(nodes.keys().skip(seed % nodes.len()).next().unwrap().as_slice()).unwrap();
@@ -5465,12 +5465,20 @@ mod benches {
 			}
 		}
 
+		// Because we've changed channel scores, its possible we'll take different routes to the
+		// selected destinations, possibly causing us to fail because, eg, the newly-selected path
+		// requires a too-high CLTV delta.
+		route_endpoints.retain(|(first_hop, params, amt)| {
+			get_route(&payer, params, &graph.read_only(), Some(&[first_hop]), *amt, 42, &DummyLogger{}, &scorer, &random_seed_bytes).is_ok()
+		});
+		route_endpoints.truncate(100);
+		assert_eq!(route_endpoints.len(), 100);
+
 		// ...then benchmark finding paths between the nodes we learned.
-		let mut idx = 0;
 		bench.iter(|| {
-			let (first_hop, params, amt) = &route_endpoints[idx % route_endpoints.len()];
-			assert!(get_route(&payer, params, &graph.read_only(), Some(&[first_hop]), *amt, 42, &DummyLogger{}, &scorer, &random_seed_bytes).is_ok());
-			idx += 1;
+			for (first_hop, params, amt) in route_endpoints.iter() {
+				assert!(get_route(&payer, params, &graph.read_only(), Some(&[first_hop]), *amt, 42, &DummyLogger{}, &scorer, &random_seed_bytes).is_ok());
+			}
 		});
 	}
 }