Skip to content

Commit c04d1c9

Browse files
authored
Merge pull request #1931 from TheBlueMatt/2022-12-1910-followups
Trivial #1910 Followups
2 parents cbbf84b + fa42b5e commit c04d1c9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

lightning/src/chain/keysinterface.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -483,10 +483,12 @@ pub trait NodeSigner {
483483
fn ecdh(&self, recipient: Recipient, other_key: &PublicKey, tweak: Option<&Scalar>) -> Result<SharedSecret, ()>;
484484

485485
/// Sign an invoice.
486+
///
486487
/// By parameterizing by the raw invoice bytes instead of the hash, we allow implementors of
487488
/// this trait to parse the invoice and make sure they're signing what they expect, rather than
488489
/// blindly signing the hash.
489-
/// The hrp is ascii bytes, while the invoice data is base32.
490+
///
491+
/// The `hrp_bytes` are ASCII bytes, while the `invoice_data` is base32.
490492
///
491493
/// The secret key used to sign the invoice is dependent on the [`Recipient`].
492494
///

lightning/src/util/test_utils.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ use bitcoin::network::constants::Network;
3636
use bitcoin::hash_types::{BlockHash, Txid};
3737

3838
use bitcoin::secp256k1::{SecretKey, PublicKey, Secp256k1, ecdsa::Signature, Scalar};
39+
use bitcoin::secp256k1::ecdh::SharedSecret;
3940
use bitcoin::secp256k1::ecdsa::RecoverableSignature;
4041

4142
use regex;
@@ -51,7 +52,6 @@ use crate::chain::keysinterface::{InMemorySigner, Recipient, KeyMaterial, Entrop
5152

5253
#[cfg(feature = "std")]
5354
use std::time::{SystemTime, UNIX_EPOCH};
54-
use bitcoin::secp256k1::ecdh::SharedSecret;
5555
use bitcoin::Sequence;
5656

5757
pub struct TestVecWriter(pub Vec<u8>);

0 commit comments

Comments
 (0)