Ignore Duplicate Gossip Error while updating networkGraph from RGS #1746

G8XSU · G8XSU · commit c48760ce84fe · 2022-10-11T15:20:33.000-04:00
diff --git a/lightning-rapid-gossip-sync/src/processing.rs b/lightning-rapid-gossip-sync/src/processing.rs
@@ -194,7 +194,14 @@ impl<NG: Deref<Target=NetworkGraph<L>>, L: Deref> RapidGossipSync<NG, L> where L
 				synthetic_update.htlc_maximum_msat = htlc_maximum_msat;
 			}
 
-			network_graph.update_channel_unsigned(&synthetic_update)?;
+			let update_channel_result = network_graph.update_channel_unsigned(&synthetic_update);
+			if let Err(error) = update_channel_result {
+				if let ErrorAction::IgnoreDuplicateGossip = error.action {
+					// Ignore
+				} else {
+					return Err(error.into());
+				}
+			}
 		}
 
 		self.network_graph.set_last_rapid_gossip_sync_timestamp(latest_seen_timestamp);

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,14 @@ impl<NG: Deref<Target=NetworkGraph<L>>, L: Deref> RapidGossipSync<NG, L> where L`
`194`	`194`	`synthetic_update.htlc_maximum_msat = htlc_maximum_msat;`
`195`	`195`	`}`
`196`	`196`
`197`		`- network_graph.update_channel_unsigned(&synthetic_update)?;`
	`197`	`+ let update_channel_result = network_graph.update_channel_unsigned(&synthetic_update);`
	`198`	`+ if let Err(error) = update_channel_result {`
	`199`	`+ if let ErrorAction::IgnoreDuplicateGossip = error.action {`
	`200`	`+ // Ignore`
	`201`	`+ } else {`
	`202`	`+ return Err(error.into());`
	`203`	`+ }`
	`204`	`+ }`
`198`	`205`	`}`
`199`	`206`
`200`	`207`	`self.network_graph.set_last_rapid_gossip_sync_timestamp(latest_seen_timestamp);`