f - Remove remaining TODOs

Author: jkczyz

lightning/src/ln/functional_tests.rs

@@ -7289,7 +7289,6 @@ fn test_check_htlc_underpaying() {
 	// Create some initial channels
 	create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
 
-	// TODO: Replace this with get_route_and_payment_hash.
 	let route = get_route(&nodes[0].node.get_our_node_id(), &nodes[0].net_graph_msg_handler.network_graph, &nodes[1].node.get_our_node_id(), Some(InvoiceFeatures::known()), None, &Vec::new(), 10_000, TEST_FINAL_CLTV, nodes[0].logger).unwrap();
 	let (_, our_payment_hash, _) = get_payment_preimage_hash!(nodes[0]);
 	let our_payment_secret = nodes[1].node.create_inbound_payment_for_hash(our_payment_hash, Some(100_000), 7200, 0).unwrap();
@@ -7763,8 +7762,6 @@ fn test_bump_penalty_txn_on_revoked_htlcs() {
 		assert_ne!(node_txn[0].input[0].previous_output, node_txn[2].input[0].previous_output);
 		assert_ne!(node_txn[1].input[0].previous_output, node_txn[2].input[0].previous_output);
 
-		// TODO: Determine why replacing get_route with get_route_and_payment_hash above causes
-		// these outputs to match differently.
 		assert_eq!(node_txn[0].input[0].previous_output, revoked_htlc_txn[0].input[0].previous_output);
 		assert_eq!(node_txn[1].input[0].previous_output, revoked_htlc_txn[2].input[0].previous_output);
 

lightning/src/ln/shutdown_tests.rs

@@ -71,9 +71,6 @@ fn pre_funding_lock_shutdown_test() {
 	check_closed_event!(nodes[1], 1, ClosureReason::CooperativeClosure);
 }
 
-// TODO: Determine why get_route fails when replacing get_payment_preimage_hash with
-// get_route_and_payment_hash. Seems using list_usable_channels instead of None for first_hops in
-// get_route_and_payment_hash is the problem.
 #[test]
 fn updates_shutdown_wait() {
 	// Test sending a shutdown with outstanding updates pending