Skip to content

Commit d2f401a

Browse files
authored
Merge pull request #1154 from TheBlueMatt/2021-11-103-doc-tweaks
0.0.103 CHANGELOG tweaks from Jeff
2 parents c0bbd4d + 7df087a commit d2f401a

File tree

1 file changed

+20
-14
lines changed

1 file changed

+20
-14
lines changed

CHANGELOG.md

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,19 @@
33
## API Updates
44
* This release is almost entirely focused on a new API in the
55
`lightning-invoice` crate - the `InvoicePayer`. `InvoicePayer` is a
6-
struct which takes a reference to a `ChannelManager` and a `NetworkGraph`
6+
struct which takes a reference to a `ChannelManager` and a `Router`
77
and retries payments as paths fail. It limits retries to a configurable
88
number, but is not serialized to disk and may retry additional times across
99
a serialization/load. In order to learn about failed payments, it must
1010
receive `Event`s directly from the `ChannelManager`, wrapping a
1111
user-provided `EventHandler` which it provides all unhandled events to
1212
(#1059).
13-
* `get_route` has been renamed `find_route` (#1059) and now takes a `Payee`
14-
struct in replacement of a number of its long list of arguments (#1134).
15-
`Payee` is further stored in the `Route` object returned and provided in the
16-
`RouteParameters` contained in `Event::PaymentPathFailed` (#1059).
17-
* `ChannelMonitor`s must now be persisted after calls which provide new block
13+
* `get_route` has been renamed `find_route` (#1059) and now takes a
14+
`RouteParameters` struct in replacement of a number of its long list of
15+
arguments (#1134). The `Payee` in the `RouteParameters` is stored in the
16+
`Route` object returned and provided in the `RouteParameters` contained in
17+
`Event::PaymentPathFailed` (#1059).
18+
* `ChannelMonitor`s must now be persisted after calls that provide new block
1819
data, prior to `MonitorEvent`s being passed back to `ChannelManager` for
1920
processing. If you are using a `ChainMonitor` this is handled for you.
2021
The `Persist` API has been updated to `Option`ally take the
@@ -29,23 +30,28 @@
2930
* `Event::PaymentSent` now includes the full fee which was spent across all
3031
payment paths which were fulfilled or pending when the payment was fulfilled
3132
(#1142).
33+
* `Event::PaymentSent` and `Event::PaymentPathFailed` now include the
34+
`PaymentId` which matches the `PaymentId` returned from
35+
`ChannelManager::send_payment` or `InvoicePayer::pay_invoice` (#1059).
3236
* `NetGraphMsgHandler` now takes a `Deref` to the `NetworkGraph`, allowing for
3337
shared references to the graph data to make serialization and references to
3438
the graph data in the `InvoicePayer`'s `Router` simpler (#1149).
3539
* `routing::Score::channel_penalty_msat` has been updated to provide the
3640
`NodeId` of both the source and destination nodes of a channel (#1133).
3741

3842
## Bug Fixes
39-
* Delay disconnecting peers if we receive messages from them even if it takes
40-
a while to receive a pong from them. Further, avoid sending too many gossip
41-
messages between pings to ensure we should always receive pongs in a timely
42-
manner. Together, these should significantly reduce instances of us failing
43-
to remain connected to a peer during initial gossip sync (#1137).
44-
* If a payment is sent, creating an outbound HTLC and sending it to our
43+
* Previous versions would often disconnect peers during initial graph sync due
44+
to ping timeouts while processing large numbers of gossip messages. We now
45+
delay disconnecting peers if we receive messages from them even if it takes
46+
a while to receive a pong from them. Further, we avoid sending too many
47+
gossip messages between pings to ensure we should always receive pongs in a
48+
timely manner (#1137).
49+
* If a payment was sent, creating an outbound HTLC and sending it to our
4550
counterparty (implying the `ChannelMonitor` was persisted on disk), but the
4651
`ChannelManager` was not persisted prior to shutdown/crash, no
47-
`Event::PaymentPathFailed` event will be generated if the HTLC is eventually
48-
failed on chain (#1104).
52+
`Event::PaymentPathFailed` event was generated if the HTLC was eventually
53+
failed on chain. Events are now consistent irrespective of `ChannelManager`
54+
persistence or non-persistence (#1104).
4955

5056
## Serialization Compatibility
5157
* All above new Events/fields are ignored by prior clients. All above new

0 commit comments

Comments
 (0)