f Just check iters

tnull · tnull · commit e61abb35d2d8 · 2025-01-06T19:34:14.000+01:00
diff --git a/lightning/src/offers/parse.rs b/lightning/src/offers/parse.rs
@@ -58,7 +58,8 @@ mod sealed {
 
 			let parsed = CheckedHrpstring::new::<NoChecksum>(encoded.as_ref())?;
 			let hrp = parsed.hrp();
-			if (hrp.as_str() != Self::BECH32_HRP) && hrp.lowercase_char_iter().ne(Self::BECH32_HRP.chars()) {
+			// Compare the lowercase'd iter to allow for all-uppercase HRPs
+			if hrp.lowercase_char_iter().ne(Self::BECH32_HRP.chars()) {
 				return Err(Bolt12ParseError::InvalidBech32Hrp);
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,8 @@ mod sealed {`
`58`	`58`
`59`	`59`	`let parsed = CheckedHrpstring::new::<NoChecksum>(encoded.as_ref())?;`
`60`	`60`	`let hrp = parsed.hrp();`
`61`		`- if (hrp.as_str() != Self::BECH32_HRP) && hrp.lowercase_char_iter().ne(Self::BECH32_HRP.chars()) {`
	`61`	`+ // Compare the lowercase'd iter to allow for all-uppercase HRPs`
	`62`	`+ if hrp.lowercase_char_iter().ne(Self::BECH32_HRP.chars()) {`
`62`	`63`	`return Err(Bolt12ParseError::InvalidBech32Hrp);`
`63`	`64`	`}`
`64`	`65`