f - remove clone from OnionHopData serialization

Author: alecchendev

lightning/src/ln/msgs.rs

@@ -1937,12 +1937,10 @@ impl Writeable for OnionHopData {
 				});
 			},
 			OnionHopDataFormat::FinalNode { ref payment_data, ref payment_metadata, ref keysend_preimage, ref custom_tlvs } => {
-				let mut custom_tlvs = custom_tlvs.clone().unwrap_or(Vec::new());
-				if let &Some(preimage) = keysend_preimage {
-					let mut preimage_bytes = Vec::new();
-					preimage.write(&mut preimage_bytes)?;
-					custom_tlvs.push((5482373484, preimage_bytes));
-				}
+				let preimage = if let Some(ref preimage) = keysend_preimage {
+					Some((5482373484, preimage.encode()))
+				} else { None };
+				let mut custom_tlvs: Vec<&(u64, Vec<u8>)> = custom_tlvs.iter().flatten().chain(preimage.iter()).collect();
 				custom_tlvs.sort_by_key(|(typ, _)| *typ);
 
 				_encode_varint_length_prefixed_tlv!(w, {