Skip to content

Commit ebeb5a4

Browse files
committed
f take the alternative approach
1 parent 82c0b28 commit ebeb5a4

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lightning/src/chain/channelmonitor.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -968,10 +968,6 @@ impl<Signer: Sign> ChannelMonitor<Signer> {
968968
/// For lockorder enforcement purposes, we need to have a single site which constructs the
969969
/// `inner` mutex, otherwise cases where we lock two monitors at the same time (eg in our
970970
/// PartialEq implementation) we may decide a lockorder violation has occurred.
971-
///
972-
/// Note that this approach may be somewhat brittle - if this method gets inlined inner mutexes
973-
/// may be considered separate again. In that case we may need to move from considering locks
974-
/// by the instruction pointer to considering locks by the symbol module and line number.
975971
fn construct_monitor(imp: ChannelMonitorImpl<Signer>) -> Self {
976972
ChannelMonitor { inner: Mutex::new(imp) }
977973
}

0 commit comments

Comments
 (0)