Skip to content

Commit ed75ce3

Browse files
committed
Drop log_bytes!() calls on Display types in ChannelManager
df3ab2e was rebased one too many times and ended up reverting some of the `log_bytes!()` removals around types which now implement `Display` in `ChannelManager`. This commit removes those, as well as one additoinal excess macro which slipped in somewhere else.
1 parent 18a18d8 commit ed75ce3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lightning/src/ln/channelmanager.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -3215,7 +3215,7 @@ where
32153215
/// [`internal_closing_signed`]: Self::internal_closing_signed
32163216
fn get_channel_update_for_unicast(&self, chan: &Channel<SP>) -> Result<msgs::ChannelUpdate, LightningError> {
32173217
let logger = WithChannelContext::from(&self.logger, &chan.context);
3218-
log_trace!(logger, "Attempting to generate channel update for channel {}", log_bytes!(chan.context.channel_id().0));
3218+
log_trace!(logger, "Attempting to generate channel update for channel {}", chan.context.channel_id());
32193219
let short_channel_id = match chan.context.get_short_channel_id().or(chan.context.latest_inbound_scid_alias()) {
32203220
None => return Err(LightningError{err: "Channel not yet established".to_owned(), action: msgs::ErrorAction::IgnoreError}),
32213221
Some(id) => id,
@@ -3226,7 +3226,7 @@ where
32263226

32273227
fn get_channel_update_for_onion(&self, short_channel_id: u64, chan: &Channel<SP>) -> Result<msgs::ChannelUpdate, LightningError> {
32283228
let logger = WithChannelContext::from(&self.logger, &chan.context);
3229-
log_trace!(logger, "Generating channel update for channel {}", log_bytes!(chan.context.channel_id().0));
3229+
log_trace!(logger, "Generating channel update for channel {}", chan.context.channel_id());
32303230
let were_node_one = self.our_network_pubkey.serialize()[..] < chan.context.get_counterparty_node_id().serialize()[..];
32313231

32323232
let enabled = chan.context.is_usable() && match chan.channel_update_status() {
@@ -6987,7 +6987,7 @@ where
69876987
},
69886988
hash_map::Entry::Vacant(_) => {
69896989
log_debug!(logger, "Sending bogus ChannelReestablish for unknown channel {} to force channel closure",
6990-
log_bytes!(msg.channel_id.0));
6990+
msg.channel_id);
69916991
// Unfortunately, lnd doesn't force close on errors
69926992
// (https://github.com/lightningnetwork/lnd/blob/abb1e3463f3a83bbb843d5c399869dbe930ad94f/htlcswitch/link.go#L2119).
69936993
// One of the few ways to get an lnd counterparty to force close is by
@@ -10425,7 +10425,7 @@ where
1042510425
hash_map::Entry::Occupied(mut entry) => {
1042610426
let newly_added = entry.get_mut().insert(session_priv_bytes, &path);
1042710427
log_info!(logger, "{} a pending payment path for {} msat for session priv {} on an existing pending payment with payment hash {}",
10428-
if newly_added { "Added" } else { "Had" }, path_amt, log_bytes!(session_priv_bytes), log_bytes!(htlc.payment_hash.0));
10428+
if newly_added { "Added" } else { "Had" }, path_amt, log_bytes!(session_priv_bytes), htlc.payment_hash);
1042910429
},
1043010430
hash_map::Entry::Vacant(entry) => {
1043110431
let path_fee = path.fee_msat();

0 commit comments

Comments
 (0)