Skip to content

Commit f27a624

Browse files
alexanderwiederinalexanderwiederin
committed
add preflight probes test coverage
1 parent 2c51080 commit f27a624

File tree

3 files changed

+168
-102
lines changed

3 files changed

+168
-102
lines changed

‎lightning/src/ln/functional_test_utils.rs

Lines changed: 64 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2097,6 +2097,26 @@ pub fn expect_channel_ready_event<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, ex
20972097
}
20982098
}
20992099

2100+
#[cfg(any(test, feature = "_test_utils"))]
2101+
pub fn expect_probe_successful_events(node: &Node, mut probe_results: Vec<(PaymentHash, PaymentId)>) {
2102+
let mut events = node.node.get_and_clear_pending_events();
2103+
2104+
for event in events.drain(..) {
2105+
match event {
2106+
Event::ProbeSuccessful { payment_hash: ev_ph, payment_id: ev_pid, ..} => {
2107+
let result_idx = probe_results.iter().position(|(payment_hash, payment_id)| *payment_hash == ev_ph && *payment_id == ev_pid);
2108+
assert!(result_idx.is_some());
2109+
2110+
probe_results.remove(result_idx.unwrap());
2111+
},
2112+
_ => panic!(),
2113+
}
2114+
};
2115+
2116+
// Ensure that we received a ProbeSuccessful event for each probe result.
2117+
assert!(probe_results.is_empty());
2118+
}
2119+
21002120
pub struct PaymentFailedConditions<'a> {
21012121
pub(crate) expected_htlc_error_data: Option<(u16, &'a [u8])>,
21022122
pub(crate) expected_blamed_scid: Option<u64>,
@@ -2234,21 +2254,41 @@ pub fn send_along_route_with_secret<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>,
22342254
payment_id
22352255
}
22362256

2237-
pub fn do_pass_along_path<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_path: &[&Node<'a, 'b, 'c>], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: Option<PaymentSecret>, ev: MessageSendEvent, payment_claimable_expected: bool, clear_recipient_events: bool, expected_preimage: Option<PaymentPreimage>) -> Option<Event> {
2257+
fn fail_payment_along_path<'a, 'b, 'c>(expected_path: &[&Node<'a, 'b, 'c>]) {
2258+
let origin_node_id = expected_path[0].node.get_our_node_id();
2259+
2260+
// iterate from the receiving node to the origin node and handle update fail htlc.
2261+
for (&node, &prev_node) in expected_path.iter().rev().zip(expected_path.iter().rev().skip(1)) {
2262+
let updates = get_htlc_update_msgs!(node, prev_node.node.get_our_node_id());
2263+
prev_node.node.handle_update_fail_htlc(&node.node.get_our_node_id(), &updates.update_fail_htlcs[0]);
2264+
check_added_monitors!(prev_node, 0);
2265+
2266+
let is_first_hop = origin_node_id == prev_node.node.get_our_node_id();
2267+
// We do not want to fail backwards on the first hop. All other hops should fail backwards.
2268+
commitment_signed_dance!(prev_node, node, updates.commitment_signed, !is_first_hop);
2269+
}
2270+
}
2271+
2272+
pub fn do_pass_along_path<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_path: &[&Node<'a, 'b, 'c>], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: Option<PaymentSecret>, ev: MessageSendEvent, payment_claimable_expected: bool, clear_recipient_events: bool, expected_preimage: Option<PaymentPreimage>, is_probe: bool) -> Option<Event> {
22382273
let mut payment_event = SendEvent::from_event(ev);
22392274
let mut prev_node = origin_node;
22402275
let mut event = None;
22412276

22422277
for (idx, &node) in expected_path.iter().enumerate() {
2278+
let is_last_hop = idx == expected_path.len() - 1;
22432279
assert_eq!(node.node.get_our_node_id(), payment_event.node_id);
22442280

22452281
node.node.handle_update_add_htlc(&prev_node.node.get_our_node_id(), &payment_event.msgs[0]);
22462282
check_added_monitors!(node, 0);
2247-
commitment_signed_dance!(node, prev_node, payment_event.commitment_msg, false);
22482283

2249-
expect_pending_htlcs_forwardable!(node);
2284+
if is_last_hop && is_probe {
2285+
commitment_signed_dance!(node, prev_node, payment_event.commitment_msg, true, true);
2286+
} else {
2287+
commitment_signed_dance!(node, prev_node, payment_event.commitment_msg, false);
2288+
expect_pending_htlcs_forwardable!(node);
2289+
}
22502290

2251-
if idx == expected_path.len() - 1 && clear_recipient_events {
2291+
if is_last_hop && clear_recipient_events {
22522292
let events_2 = node.node.get_and_clear_pending_events();
22532293
if payment_claimable_expected {
22542294
assert_eq!(events_2.len(), 1);
@@ -2282,7 +2322,7 @@ pub fn do_pass_along_path<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_p
22822322
} else {
22832323
assert!(events_2.is_empty());
22842324
}
2285-
} else if idx != expected_path.len() - 1 {
2325+
} else if !is_last_hop {
22862326
let mut events_2 = node.node.get_and_clear_pending_msg_events();
22872327
assert_eq!(events_2.len(), 1);
22882328
check_added_monitors!(node, 1);
@@ -2296,16 +2336,33 @@ pub fn do_pass_along_path<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_p
22962336
}
22972337

22982338
pub fn pass_along_path<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_path: &[&Node<'a, 'b, 'c>], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: Option<PaymentSecret>, ev: MessageSendEvent, payment_claimable_expected: bool, expected_preimage: Option<PaymentPreimage>) -> Option<Event> {
2299-
do_pass_along_path(origin_node, expected_path, recv_value, our_payment_hash, our_payment_secret, ev, payment_claimable_expected, true, expected_preimage)
2339+
do_pass_along_path(origin_node, expected_path, recv_value, our_payment_hash, our_payment_secret, ev, payment_claimable_expected, true, expected_preimage, false)
2340+
}
2341+
2342+
pub fn pass_probe_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&[&Node<'a, 'b, 'c>]]) {
2343+
let mut events = origin_node.node.get_and_clear_pending_msg_events();
2344+
assert_eq!(events.len(), expected_route.len());
2345+
2346+
check_added_monitors!(origin_node, expected_route.len());
2347+
2348+
for path in expected_route.iter() {
2349+
let ev = remove_first_msg_event_to_node(&path[0].node.get_our_node_id(), &mut events);
2350+
2351+
do_pass_along_path(origin_node, path, 0, PaymentHash([0_u8; 32]), None, ev, false, false, None, true);
2352+
let nodes_to_fail_payment: Vec<_> = vec![origin_node].into_iter().chain(path.iter().cloned()).collect();
2353+
2354+
fail_payment_along_path(nodes_to_fail_payment.as_slice());
2355+
}
23002356
}
23012357

23022358
pub fn pass_along_route<'a, 'b, 'c>(origin_node: &Node<'a, 'b, 'c>, expected_route: &[&[&Node<'a, 'b, 'c>]], recv_value: u64, our_payment_hash: PaymentHash, our_payment_secret: PaymentSecret) {
23032359
let mut events = origin_node.node.get_and_clear_pending_msg_events();
23042360
assert_eq!(events.len(), expected_route.len());
2361+
23052362
for (path_idx, expected_path) in expected_route.iter().enumerate() {
23062363
let ev = remove_first_msg_event_to_node(&expected_path[0].node.get_our_node_id(), &mut events);
23072364
// Once we've gotten through all the HTLCs, the last one should result in a
2308-
// PaymentClaimable (but each previous one should not!), .
2365+
// PaymentClaimable (but each previous one should not!).
23092366
let expect_payment = path_idx == expected_route.len() - 1;
23102367
pass_along_path(origin_node, expected_path, recv_value, our_payment_hash.clone(), Some(our_payment_secret), ev, expect_payment, None);
23112368
}

‎lightning/src/ln/payment_tests.rs

Lines changed: 102 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -1277,48 +1277,17 @@ fn successful_probe_yields_event() {
12771277
create_announced_chan_between_nodes(&nodes, 0, 1);
12781278
create_announced_chan_between_nodes(&nodes, 1, 2);
12791279

1280-
let (route, _, _, _) = get_route_and_payment_hash!(&nodes[0], nodes[2], 100_000);
1280+
let recv_value = 100_000;
1281+
let (route, payment_hash, _, _) = get_route_and_payment_hash!(&nodes[0], nodes[2], recv_value);
12811282

1282-
let (payment_hash, payment_id) = nodes[0].node.send_probe(route.paths[0].clone()).unwrap();
1283+
let res = nodes[0].node.send_probe(route.paths[0].clone()).unwrap();
12831284

1284-
// node[0] -- update_add_htlcs -> node[1]
1285-
check_added_monitors!(nodes[0], 1);
1286-
let updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
1287-
let probe_event = SendEvent::from_commitment_update(nodes[1].node.get_our_node_id(), updates);
1288-
nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &probe_event.msgs[0]);
1289-
check_added_monitors!(nodes[1], 0);
1290-
commitment_signed_dance!(nodes[1], nodes[0], probe_event.commitment_msg, false);
1291-
expect_pending_htlcs_forwardable!(nodes[1]);
1285+
let expected_route: &[&[&Node]] = &[&[&nodes[1], &nodes[2]]];
12921286

1293-
// node[1] -- update_add_htlcs -> node[2]
1294-
check_added_monitors!(nodes[1], 1);
1295-
let updates = get_htlc_update_msgs!(nodes[1], nodes[2].node.get_our_node_id());
1296-
let probe_event = SendEvent::from_commitment_update(nodes[1].node.get_our_node_id(), updates);
1297-
nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &probe_event.msgs[0]);
1298-
check_added_monitors!(nodes[2], 0);
1299-
commitment_signed_dance!(nodes[2], nodes[1], probe_event.commitment_msg, true, true);
1287+
pass_probe_along_route(&nodes[0], expected_route);
13001288

1301-
// node[1] <- update_fail_htlcs -- node[2]
1302-
let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1303-
nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
1304-
check_added_monitors!(nodes[1], 0);
1305-
commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, true);
1306-
1307-
// node[0] <- update_fail_htlcs -- node[1]
1308-
let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1309-
nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
1310-
check_added_monitors!(nodes[0], 0);
1311-
commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
1289+
expect_probe_successful_events(&nodes[0], vec![res]);
13121290

1313-
let mut events = nodes[0].node.get_and_clear_pending_events();
1314-
assert_eq!(events.len(), 1);
1315-
match events.drain(..).next().unwrap() {
1316-
crate::events::Event::ProbeSuccessful { payment_id: ev_pid, payment_hash: ev_ph, .. } => {
1317-
assert_eq!(payment_id, ev_pid);
1318-
assert_eq!(payment_hash, ev_ph);
1319-
},
1320-
_ => panic!(),
1321-
};
13221291
assert!(!nodes[0].node.has_pending_payments());
13231292
}
13241293

@@ -1423,6 +1392,94 @@ fn onchain_failed_probe_yields_event() {
14231392
assert!(!nodes[0].node.has_pending_payments());
14241393
}
14251394

1395+
#[test]
1396+
fn preflight_probes_yield_event_skip_private_hop() {
1397+
let chanmon_cfgs = create_chanmon_cfgs(5);
1398+
let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
1399+
1400+
// We alleviate the HTLC max-in-flight limit, as otherwise we'd always be limited through that.
1401+
let mut no_htlc_limit_config = test_default_channel_config();
1402+
no_htlc_limit_config.channel_handshake_config.max_inbound_htlc_value_in_flight_percent_of_channel = 100;
1403+
1404+
let user_configs = std::iter::repeat(no_htlc_limit_config).take(5).map(|c| Some(c)).collect::<Vec<Option<UserConfig>>>();
1405+
let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &user_configs);
1406+
let nodes = create_network(5, &node_cfgs, &node_chanmgrs);
1407+
1408+
// Setup channel topology:
1409+
// N0 -(1M:0)- N1 -(1M:0)- N2 -(70k:0)- N3 -(50k:0)- N4
1410+
1411+
create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
1412+
create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
1413+
create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 70_000, 0);
1414+
create_unannounced_chan_between_nodes_with_value(&nodes, 3, 4, 50_000, 0);
1415+
1416+
let mut invoice_features = Bolt11InvoiceFeatures::empty();
1417+
invoice_features.set_basic_mpp_optional();
1418+
1419+
let payment_params = PaymentParameters::from_node_id(nodes[3].node.get_our_node_id(), TEST_FINAL_CLTV)
1420+
.with_bolt11_features(invoice_features).unwrap();
1421+
1422+
let recv_value = 50_000_000;
1423+
let route_params = RouteParameters::from_payment_params_and_value(payment_params, recv_value);
1424+
let res = nodes[0].node.send_preflight_probes(route_params, None).unwrap();
1425+
1426+
let expected_route: &[&[&Node]] = &[&[&nodes[1], &nodes[2], &nodes[3]]];
1427+
1428+
assert_eq!(res.len(), expected_route.len());
1429+
1430+
pass_probe_along_route(&nodes[0], expected_route);
1431+
1432+
expect_probe_successful_events(&nodes[0], res.clone());
1433+
1434+
assert!(!nodes[0].node.has_pending_payments());
1435+
}
1436+
1437+
#[test]
1438+
fn preflight_probes_yield_event() {
1439+
let chanmon_cfgs = create_chanmon_cfgs(4);
1440+
let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1441+
1442+
// We alleviate the HTLC max-in-flight limit, as otherwise we'd always be limited through that.
1443+
let mut no_htlc_limit_config = test_default_channel_config();
1444+
no_htlc_limit_config.channel_handshake_config.max_inbound_htlc_value_in_flight_percent_of_channel = 100;
1445+
1446+
let user_configs = std::iter::repeat(no_htlc_limit_config).take(4).map(|c| Some(c)).collect::<Vec<Option<UserConfig>>>();
1447+
let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &user_configs);
1448+
let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1449+
1450+
// Setup channel topology:
1451+
// (1M:0)- N1 -(30k:0)
1452+
// / \
1453+
// N0 N4
1454+
// \ /
1455+
// (1M:0)- N2 -(70k:0)
1456+
//
1457+
create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
1458+
create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 1_000_000, 0);
1459+
create_announced_chan_between_nodes_with_value(&nodes, 1, 3, 30_000, 0);
1460+
create_announced_chan_between_nodes_with_value(&nodes, 2, 3, 70_000, 0);
1461+
1462+
let mut invoice_features = Bolt11InvoiceFeatures::empty();
1463+
invoice_features.set_basic_mpp_optional();
1464+
1465+
let payment_params = PaymentParameters::from_node_id(nodes[3].node.get_our_node_id(), TEST_FINAL_CLTV)
1466+
.with_bolt11_features(invoice_features).unwrap();
1467+
1468+
let recv_value = 50_000_000;
1469+
let route_params = RouteParameters::from_payment_params_and_value(payment_params, recv_value);
1470+
let res = nodes[0].node.send_preflight_probes(route_params, None).unwrap();
1471+
1472+
let expected_route: &[&[&Node]] = &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]];
1473+
1474+
assert_eq!(res.len(), expected_route.len());
1475+
1476+
pass_probe_along_route(&nodes[0], expected_route);
1477+
1478+
expect_probe_successful_events(&nodes[0], res.clone());
1479+
1480+
assert!(!nodes[0].node.has_pending_payments());
1481+
}
1482+
14261483
#[test]
14271484
fn preflight_probes_yield_event_and_skip() {
14281485
let chanmon_cfgs = create_chanmon_cfgs(5);
@@ -1443,7 +1500,7 @@ fn preflight_probes_yield_event_and_skip() {
14431500
// \ /
14441501
// (70k:0)- N3 -(1M:0)
14451502
//
1446-
let first_chan_update = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100_000, 0).0;
1503+
create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100_000, 0);
14471504
create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 30_000, 0);
14481505
create_announced_chan_between_nodes_with_value(&nodes, 1, 3, 70_000, 0);
14491506
create_announced_chan_between_nodes_with_value(&nodes, 2, 4, 1_000_000, 0);
@@ -1452,70 +1509,22 @@ fn preflight_probes_yield_event_and_skip() {
14521509
let mut invoice_features = Bolt11InvoiceFeatures::empty();
14531510
invoice_features.set_basic_mpp_optional();
14541511

1455-
let mut payment_params = PaymentParameters::from_node_id(nodes[4].node.get_our_node_id(), TEST_FINAL_CLTV)
1512+
let payment_params = PaymentParameters::from_node_id(nodes[4].node.get_our_node_id(), TEST_FINAL_CLTV)
14561513
.with_bolt11_features(invoice_features).unwrap();
14571514

1458-
let route_params = RouteParameters::from_payment_params_and_value(payment_params, 80_000_000);
1515+
let recv_value = 80_000_000;
1516+
let route_params = RouteParameters::from_payment_params_and_value(payment_params, recv_value);
14591517
let res = nodes[0].node.send_preflight_probes(route_params, None).unwrap();
14601518

1519+
let expected_route : &[&[&Node]] = &[&[&nodes[1], &nodes[2], &nodes[4]]];
1520+
14611521
// We check that only one probe was sent, the other one was skipped due to limited liquidity.
14621522
assert_eq!(res.len(), 1);
1463-
let log_msg = format!("Skipped sending payment probe to avoid putting channel {} under the liquidity limit.",
1464-
first_chan_update.contents.short_channel_id);
1465-
node_cfgs[0].logger.assert_log_contains("lightning::ln::channelmanager", &log_msg, 1);
14661523

1467-
let (payment_hash, payment_id) = res.first().unwrap();
1524+
pass_probe_along_route(&nodes[0], expected_route);
14681525

1469-
// node[0] -- update_add_htlcs -> node[1]
1470-
check_added_monitors!(nodes[0], 1);
1471-
let probe_event = SendEvent::from_node(&nodes[0]);
1472-
nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &probe_event.msgs[0]);
1473-
check_added_monitors!(nodes[1], 0);
1474-
commitment_signed_dance!(nodes[1], nodes[0], probe_event.commitment_msg, false);
1475-
expect_pending_htlcs_forwardable!(nodes[1]);
1526+
expect_probe_successful_events(&nodes[0], res.clone());
14761527

1477-
// node[1] -- update_add_htlcs -> node[2]
1478-
check_added_monitors!(nodes[1], 1);
1479-
let probe_event = SendEvent::from_node(&nodes[1]);
1480-
nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &probe_event.msgs[0]);
1481-
check_added_monitors!(nodes[2], 0);
1482-
commitment_signed_dance!(nodes[2], nodes[1], probe_event.commitment_msg, false);
1483-
expect_pending_htlcs_forwardable!(nodes[2]);
1484-
1485-
// node[2] -- update_add_htlcs -> node[4]
1486-
check_added_monitors!(nodes[2], 1);
1487-
let probe_event = SendEvent::from_node(&nodes[2]);
1488-
nodes[4].node.handle_update_add_htlc(&nodes[2].node.get_our_node_id(), &probe_event.msgs[0]);
1489-
check_added_monitors!(nodes[4], 0);
1490-
commitment_signed_dance!(nodes[4], nodes[2], probe_event.commitment_msg, true, true);
1491-
1492-
// node[2] <- update_fail_htlcs -- node[4]
1493-
let updates = get_htlc_update_msgs!(nodes[4], nodes[2].node.get_our_node_id());
1494-
nodes[2].node.handle_update_fail_htlc(&nodes[4].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
1495-
check_added_monitors!(nodes[2], 0);
1496-
commitment_signed_dance!(nodes[2], nodes[4], updates.commitment_signed, true);
1497-
1498-
// node[1] <- update_fail_htlcs -- node[2]
1499-
let updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
1500-
nodes[1].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
1501-
check_added_monitors!(nodes[1], 0);
1502-
commitment_signed_dance!(nodes[1], nodes[2], updates.commitment_signed, true);
1503-
1504-
// node[0] <- update_fail_htlcs -- node[1]
1505-
let updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
1506-
nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
1507-
check_added_monitors!(nodes[0], 0);
1508-
commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
1509-
1510-
let mut events = nodes[0].node.get_and_clear_pending_events();
1511-
assert_eq!(events.len(), 1);
1512-
match events.drain(..).next().unwrap() {
1513-
crate::events::Event::ProbeSuccessful { payment_id: ev_pid, payment_hash: ev_ph, .. } => {
1514-
assert_eq!(*payment_id, ev_pid);
1515-
assert_eq!(*payment_hash, ev_ph);
1516-
},
1517-
_ => panic!(),
1518-
};
15191528
assert!(!nodes[0].node.has_pending_payments());
15201529
}
15211530

‎lightning/src/ln/reload_tests.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -749,8 +749,8 @@ fn do_test_partial_claim_before_restart(persist_both_monitors: bool) {
749749
assert_eq!(send_events.len(), 2);
750750
let node_1_msgs = remove_first_msg_event_to_node(&nodes[1].node.get_our_node_id(), &mut send_events);
751751
let node_2_msgs = remove_first_msg_event_to_node(&nodes[2].node.get_our_node_id(), &mut send_events);
752-
do_pass_along_path(&nodes[0], &[&nodes[1], &nodes[3]], 15_000_000, payment_hash, Some(payment_secret), node_1_msgs, true, false, None);
753-
do_pass_along_path(&nodes[0], &[&nodes[2], &nodes[3]], 15_000_000, payment_hash, Some(payment_secret), node_2_msgs, true, false, None);
752+
do_pass_along_path(&nodes[0], &[&nodes[1], &nodes[3]], 15_000_000, payment_hash, Some(payment_secret), node_1_msgs, true, false, None, false);
753+
do_pass_along_path(&nodes[0], &[&nodes[2], &nodes[3]], 15_000_000, payment_hash, Some(payment_secret), node_2_msgs, true, false, None, false);
754754

755755
// Now that we have an MPP payment pending, get the latest encoded copies of nodes[3]'s
756756
// monitors and ChannelManager, for use later, if we don't want to persist both monitors.

0 commit comments

Comments
 (0)