Skip to content

Fix remaining feedback and other nits for 2989 #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented Aug 2, 2024

Closes #3170

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.74%. Comparing base (8c1b3d1) to head (016d7e1).

Files Patch % Lines
lightning/src/ln/interactivetxs.rs 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3219      +/-   ##
==========================================
+ Coverage   89.69%   89.74%   +0.05%     
==========================================
  Files         122      122              
  Lines      101791   101791              
  Branches   101791   101791              
==========================================
+ Hits        91300    91354      +54     
+ Misses       7791     7755      -36     
+ Partials     2700     2682      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dunxen dunxen force-pushed the 2024-08-PR2989-followups branch from 775902d to 016d7e1 Compare August 2, 2024 10:10
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All super straightforward changes, gonna just land this.

@TheBlueMatt TheBlueMatt merged commit 8eff650 into lightningdevkit:main Aug 6, 2024
17 of 19 checks passed
@dunxen dunxen deleted the 2024-08-PR2989-followups branch August 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#2989 Followups
2 participants