Skip to content

Commit 564eb5c

Browse files
author
Igor Susman
committed
add conf, kafka module doesnt read [darkstar.lqm.io:9092, localhost:9092] as suggested on dpkp/kafka-python#122
1 parent c0aff6b commit 564eb5c

File tree

3 files changed

+33
-31
lines changed

3 files changed

+33
-31
lines changed

collectd2kafka.py

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from kafka.client import KafkaClient
44
from kafka.producer import SimpleProducer
55

6-
COLLECTD_PYTHON_CONF = '/etc/collectd/collectd2kafka.py.conf'
6+
COLLECTD_PYTHON_CONF = '/home/igor/code/collectd2kafka/collectd2kafka.py.conf'
77

88
def parse_types_file(path):
99
f = open(path, 'r')
@@ -37,46 +37,42 @@ def parse_types_file(path):
3737

3838
def get_config():
3939
config = conf_p.ConfigParser()
40-
config.read(CONFIG_FILE)
40+
config.read(COLLECTD_PYTHON_CONF)
4141
global KAFKA_BROKERS
4242
global TOPIC
4343
global TYPES
4444
KAFKA_BROKERS = []
4545
TYPES = {}
46-
for x in config.get('collectd2kafka', 'Brokers')
47-
KAFKA_BROKERS.append(x)
46+
KAFKA_BROKERS.append(config.get('collectd2kafka', 'Brokers'))
4847
TOPIC = config.get('collectd2kafka', 'Topic')
4948
TYPES.update(parse_types_file(config.get('collectd2kafka', 'TypesDB')))
5049

51-
def config_callback(conf):
52-
global KAFKA_BROKERS
53-
global TOPIC
54-
global TYPES
55-
KAFKA_BROKERS = []
56-
TYPES = {}
57-
58-
59-
for node in conf.children:
60-
if node.key == 'Brokers':
61-
for x in node.values:
62-
print x
63-
KAFKA_BROKERS.append(x)
64-
elif node.key == 'Topic':
65-
TOPIC = node.values[0]
66-
elif node.key == 'TypesDB':
67-
for x in node.values:
68-
TYPES.update(parse_types_file(x))
69-
50+
#def config_callback(conf):
51+
# global KAFKA_BROKERS
52+
# global TOPIC
53+
# global TYPES
54+
# KAFKA_BROKERS = []
55+
# TYPES = {}
56+
# for node in conf.children:
57+
# if node.key == 'Brokers':
58+
# for x in node.values:
59+
# print x
60+
# KAFKA_BROKERS.append(x)
61+
# elif node.key == 'Topic':
62+
# TOPIC = node.values[0]
63+
# elif node.key == 'TypesDB':
64+
# for x in node.values:
65+
# TYPES.update(parse_types_file(x))
7066

7167
def write_callback(v, data=None):
7268
if v.type not in TYPES:
73-
collectd.warning('collectd2kafka: cannot handle type %s. check types.db file?' % v.type)
69+
collectd.warning('collectd2kafka: cannot handle type %s. check types.db file' % v.type)
7470
return
7571

7672
v_type = TYPES[v.type]
7773

7874
if len(v_type) != len(v.values):
79-
collectd.warning('collectd2kafka: more values than type %s' % v.type)
75+
collectd.warning('collectd2kafka: more values than types %s' % v.type)
8076
return
8177

8278

@@ -99,12 +95,10 @@ def write_callback(v, data=None):
9995
metric['values'].append(value)
10096

10197
producer.send_messages(TOPIC, json.dumps(metric))
102-
print "!!!!!!!!!!!!!!!!!!!"
103-
print str(KAFKA_BROKERS)
104-
print "!!!!!!!!!!!!!!!!!!!"
10598

106-
get_config();
107-
#collectd.register_config(config_callback);
108-
collectd.register_write(write_callback);
99+
get_config()
100+
print KAFKA_BROKERS
101+
#collectd.register_config(config_callback)
109102
kafka = KafkaClient(KAFKA_BROKERS)
110103
producer = SimpleProducer(kafka)
104+
collectd.register_write(write_callback)

collectd2kafka.py.conf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[collectd2kafka]
2+
Brokers: darkstar.lqm.io:9092, localhost:9092
3+
Topic: collectd
4+
TypesDB: /usr/share/collectd/types.db

test.con

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[collectd2kafka]
2+
Brokers: darkstar.lqm.io:9092, localhost:9092
3+
Topic: collectd
4+
TypesDB: /usr/share/collectd/types.db

0 commit comments

Comments
 (0)