Skip to content

Commit 03bdfb6

Browse files
[lldb][test][FreeBSD] Fix some concurrent event tests (#84155)
A lot of `TestConcurrent*.py` expect one of the threads to crash, but we weren't checking for it properly. Possibly because signal reporting got better on FreeBSD at some point, and it now shows the same info as Linux does. ``` lldb-api :: functionalities/inferior-changed/TestInferiorChanged.py lldb-api :: functionalities/inferior-crashing/TestInferiorCrashing.py lldb-api :: functionalities/inferior-crashing/TestInferiorCrashingStep.py lldb-api :: functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py lldb-api :: functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py lldb-api :: functionalities/thread/concurrent_events/TestConcurrentCrashWithBreak.py lldb-api :: functionalities/thread/concurrent_events/TestConcurrentCrashWithSignal.py lldb-api :: functionalities/thread/concurrent_events/TestConcurrentCrashWithWatchpoint.py lldb-api :: functionalities/thread/concurrent_events/TestConcurrentCrashWithWatchpointBreakpointSignal.py ``` Fixes #48777 `TestConcurrentTwoBreakpointsOneSignal.py` no longer fails, at least on an AWS instance, so I've removed the xfail there.
1 parent b6f050f commit 03bdfb6

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

lldb/packages/Python/lldbsuite/test/lldbutil.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ def is_thread_crashed(test, thread):
809809
thread.GetStopReason() == lldb.eStopReasonException
810810
and "EXC_BAD_ACCESS" in thread.GetStopDescription(100)
811811
)
812-
elif test.getPlatform() == "linux":
812+
elif test.getPlatform() in ["linux", "freebsd"]:
813813
return (
814814
thread.GetStopReason() == lldb.eStopReasonSignal
815815
and thread.GetStopReasonDataAtIndex(0)

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoBreakpointsOneSignal.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ class ConcurrentTwoBreakpointsOneSignal(ConcurrentEventsBase):
88
# Atomic sequences are not supported yet for MIPS in LLDB.
99
@skipIf(triple="^mips")
1010
@expectedFlakeyNetBSD
11-
@expectedFailureAll(
12-
archs=["aarch64"], oslist=["freebsd"], bugnumber="llvm.org/pr49433"
13-
)
1411
def test(self):
1512
"""Test two threads that trigger a breakpoint and one signal thread."""
1613
self.build()

0 commit comments

Comments
 (0)