Skip to content

Commit 052c704

Browse files
authored
[lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (#141220)
`parseAndLoadModuleMapFile` returns `true` on error. This seems to have always been an issue? This is now preventing me from fixing a different modules related issue. So this patch checks the return value correctly.
1 parent 692d9f2 commit 052c704

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ bool ClangModulesDeclVendorImpl::AddModule(const SourceModule &module,
330330
auto file = HS.lookupModuleMapFile(*dir, is_framework);
331331
if (!file)
332332
return error();
333-
if (!HS.parseAndLoadModuleMapFile(*file, is_system))
333+
if (HS.parseAndLoadModuleMapFile(*file, is_system))
334334
return error();
335335
}
336336
}

0 commit comments

Comments
 (0)