Skip to content

Commit 08b970d

Browse files
author
Peiming Liu
committed
address comments
1 parent 2b8e679 commit 08b970d

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensor.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ struct COOSegment {
5858
}
5959
};
6060

61-
/// A simple wrapper to encode a bitset of defined (at most 64) levels.
61+
/// A simple wrapper to encode a bitset of (at most 64) levels, currently used
62+
/// by `sparse_tensor.iterate` operation for the set of levels on which the
63+
/// coordinates should be loaded.
6264
class LevelSet {
6365
uint64_t bits = 0;
6466

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1526,7 +1526,7 @@ def IterateOp : SparseTensor_Op<"iterate",
15261526
["getEntrySuccessorOperands"]>,
15271527
SingleBlockImplicitTerminator<"sparse_tensor::YieldOp">]> {
15281528

1529-
let summary = "Iterate over a sparse iteration space";
1529+
let summary = "Iterates over a sparse iteration space";
15301530
let description = [{
15311531
The `sparse_tensor.iterate` operation represents a loop (nest) over
15321532
the provided iteration space extracted from a specific sparse tensor.

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2137,7 +2137,7 @@ parseSparseSpaceLoop(OpAsmParser &parser, OperationState &state,
21372137
SmallVector<OpAsmParser::UnresolvedOperand> spaces;
21382138
SmallVector<OpAsmParser::UnresolvedOperand> initArgs;
21392139

2140-
// Parses "%iters, ... in %spaces, ..."
2140+
// Parse "%iters, ... in %spaces, ..."
21412141
if (parser.parseArgumentList(iterators) || parser.parseKeyword("in") ||
21422142
parser.parseOperandList(spaces))
21432143
return failure();

0 commit comments

Comments
 (0)