-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit 0a7bf3a
authored
[CodeLayout] Faster basic block reordering, ext-tsp (#68275)
Aggressive inlining might produce huge functions with >10K of basic
blocks. Since BFI treats _all_ blocks and jumps as "hot" having
non-negative (but perhaps small) weight, the current implementation can
be slow, taking minutes to produce an layout. This change introduces a
few modifications that significantly (up to 50x on some instances)
speeds up the computation. Some notable changes:
- reduced the maximum chain size to 512 (from the prior 4096);
- introeuced MaxMergeDensityRatio param to avoid merging chains with
very differen densities;
- dropped a couple of params that seem unnecessary.
Looking at some "offline" metrics (e.g., the number of created
fall-throughs), there shouldn't be problems; in fact, I do see some
metrics go up. But it might be hard/impossible to measure perf
difference for such small changes. I did test the performance clang-14
binary and do not record a perf or i-cache-related differences.
My 5 benchmarks, with ext-tsp runtime (the lower the better) and
"tsp-score" (the higher the better).
**Before**:
- benchmark 1:
reordering running time is 2486 milliseconds
score: 125503458 (128.3102%)
- benchmark 2:
reordering running time is 3443 milliseconds
score: 12613997277 (129.7495%)
- benchmark 2:
reordering running time is 1978 milliseconds
score: 1315881613 (105.8991%)
- benchmark 4:
reordering running time is 7364 milliseconds
score: 89513906284 (100.3413%)
- benchmark 5:
reordering running time is 372605 milliseconds
score: 21292505965077 (99.9979%)
**After**:
- benchmark 1:
reordering running time is 2498 milliseconds
score: 125510418 (128.3173%)
- benchmark 2:
reordering running time is 3201 milliseconds
score: 12614502162 (129.7547%)
- benchmark 3:
reordering running time is 2137 milliseconds
score: 1315938168 (105.9036%)
- benchmark 4:
reordering running time is 6242 milliseconds
score: 89518095837 (100.3460%)
- benchmark 5:
reordering running time is 5819 milliseconds
score: 21292295939119 (99.9969%)1 parent 0abaf3c commit 0a7bf3aCopy full SHA for 0a7bf3a
1 file changed
+143
-100
lines changed
0 commit comments