[clang] Remove rdar links; NFC

We have a new policy in place making links to private resources
something we try to avoid in source and test files. Normally, we'd
organically switch to the new policy rather than make a sweeping change
across a project. However, Clang is in a somewhat special circumstance
currently: recently, I've had several new contributors run into rdar
links around test code which their patch was changing the behavior of.
This turns out to be a surprisingly bad experience, especially for
newer folks, for a handful of reasons: not understanding what the link
is and feeling intimidated by it, wondering whether their changes are
actually breaking something important to a downstream in some way,
having to hunt down strangers not involved with the patch to impose on
them for help, accidental pressure from asking for potentially private
IP to be made public, etc. Because folks run into these links entirely
by chance (through fixing bugs or working on new features), there's not
really a set of problematic links to focus on -- all of the links have
basically the same potential for causing these problems. As a result,
this is an omnibus patch to remove all such links.

This was not a mechanical change; it was done by manually searching for
rdar, radar, radr, and other variants to find all the various
problematic links. From there, I tried to retain or reword the
surrounding comments so that we would lose as little context as
possible. However, because most links were just a plain link with no
supporting context, the majority of the changes are simple removals.

Differential Review: https://reviews.llvm.org/D158071

Author: AaronBallman

clang/lib/Analysis/RetainSummaryManager.cpp

@@ -395,7 +395,7 @@ const RetainSummary *RetainSummaryManager::getSummaryForObjCOrCFObject(
     return getDoNothingSummary();
   } else if (FName.startswith("NS") && FName.contains("Insert")) {
     // Allowlist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can
-    // be deallocated by NSMapRemove. (radar://11152419)
+    // be deallocated by NSMapRemove.
     ScratchArgs = AF.add(ScratchArgs, 1, ArgEffect(StopTracking));
     ScratchArgs = AF.add(ScratchArgs, 2, ArgEffect(StopTracking));
     return getPersistentSummary(RetEffect::MakeNoRet(),

clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp

@@ -79,7 +79,6 @@ void UndefResultChecker::checkPostStmt(const BinaryOperator *B,
 
     // Do not report assignments of uninitialized values inside swap functions.
     // This should allow to swap partially uninitialized structs
-    // (radar://14129997)
     if (const FunctionDecl *EnclosingFunctionDecl =
         dyn_cast<FunctionDecl>(C.getStackFrame()->getDecl()))
       if (C.getCalleeName(EnclosingFunctionDecl) == "swap")

clang/lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp

@@ -39,7 +39,6 @@ void UndefinedAssignmentChecker::checkBind(SVal location, SVal val,
 
   // Do not report assignments of uninitialized values inside swap functions.
   // This should allow to swap partially uninitialized structs
-  // (radar://14129997)
   if (const FunctionDecl *EnclosingFunctionDecl =
       dyn_cast<FunctionDecl>(C.getStackFrame()->getDecl()))
     if (C.getCalleeName(EnclosingFunctionDecl) == "swap")

clang/test/ARCMT/GC-check-warn-nsalloc.m

@@ -1,7 +1,6 @@
 // RUN: %clang_cc1 -arcmt-action=check -no-ns-alloc-error -triple x86_64-apple-darwin10 -fobjc-gc-only %s 2>&1 | grep 'warning: \[rewriter\] call returns pointer to GC managed memory'
 // RUN: %clang_cc1 -arcmt-action=check -no-ns-alloc-error -triple x86_64-apple-darwin10 -fobjc-gc-only -x objective-c++ %s 2>&1 | grep 'warning: \[rewriter\] call returns pointer to GC managed memory'
 // TODO: Investigate VerifyDiagnosticConsumer failures on these tests when using -verify.
-// rdar://10532541
 
 typedef unsigned NSUInteger;
 void *__strong NSAllocateCollectable(NSUInteger size, NSUInteger options);

clang/test/ARCMT/GC-no-finalize-removal.m

@@ -77,7 +77,6 @@ -(void)test1:(CFTypeRef *)cft {
 }
 @end
 
-// rdar://10532449
 @interface rdar10532449
 @property (assign) id assign_prop;
 @property (assign, readonly) id __strong strong_readonly_prop;

clang/test/ARCMT/GC-no-finalize-removal.m.result

@@ -85,7 +85,6 @@ __attribute__((objc_arc_weak_reference_unavailable))
 }
 @end
 
-// rdar://10532449
 @interface rdar10532449
 @property (strong) id assign_prop;
 @property (strong, readonly) id  strong_readonly_prop;

clang/test/ARCMT/GC.m

@@ -77,7 +77,6 @@ -(void)test1:(CFTypeRef *)cft {
 }
 @end
 
-// rdar://10532449
 @interface rdar10532449
 @property (assign) id assign_prop;
 @property (assign, readonly) id __strong strong_readonly_prop;

clang/test/ARCMT/GC.m.result

@@ -72,7 +72,6 @@ __attribute__((objc_arc_weak_reference_unavailable))
 }
 @end
 
-// rdar://10532449
 @interface rdar10532449
 @property (strong) id assign_prop;
 @property (strong, readonly) id  strong_readonly_prop;

clang/test/ARCMT/check-with-pch.m

@@ -2,7 +2,6 @@
 // RUN: %clang_cc1 -include-pch %t.pch -arcmt-action=check -verify -triple x86_64-apple-darwin10 -fblocks -Werror %s
 // REQUIRES: x86-registered-target
 
-// rdar://9601437
 @interface I9601437 {
   __unsafe_unretained id x;
 }

clang/test/ARCMT/checking.m

@@ -288,7 +288,6 @@ id test9(Test9 *v) {
   return [v init1];
 }
 
-// rdar://9491791
 void rdar9491791(int p) {
   switch (p) {
   case 3:;
@@ -302,12 +301,10 @@ void rdar9491791(int p) {
 
 #define RELEASE_MACRO(x) do { [x release]; } while(1)
 
-// rdar://9504750
 void rdar9504750(id p) {
   RELEASE_MACRO(p); // expected-error {{ARC forbids explicit message send of 'release'}} 
 }
 
-// rdar://8939557
 @interface TestReadonlyProperty : NSObject
 @property(assign,readonly) NSObject *value;
 @end
@@ -319,7 +316,6 @@ - (void)viewDidLoad {
 }
 @end
 
-// rdar://9601437
 @interface I9601437 {
   __unsafe_unretained id x;
 }

clang/test/ARCMT/no-canceling-bridge-to-bridge-cast.m

@@ -1,5 +1,4 @@
 // RUN: %clang_cc1 -arcmt-action=check -triple x86_64-apple-darwin10 -fsyntax-only -x objective-c -verify %s
-// rdar://10387088
 typedef const void * CFTypeRef;
 CFTypeRef CFBridgingRetain(id X);
 id CFBridgingRelease(CFTypeRef);

clang/test/ARCMT/nonobjc-to-objc-cast-2.m

@@ -56,7 +56,6 @@ CFStringRef f3(void) {
 
 extern void NSLog(NSString *format, ...);
 
-// rdar://13192395
 void f4(NSString *s) {
   NSLog(@"%@", (CFStringRef)s); // expected-error {{cast of Objective-C pointer type 'NSString *' to C pointer type 'CFStringRef' (aka 'const struct __CFString *') requires a bridged cast}} \
     // expected-note{{use __bridge to convert directly (no change in ownership)}} \