Skip to content

Commit 1660a41

Browse files
committed
Handle review comments (2).
Set isLocalToUnit to false to get DW_AT_external=true in DWARF.
1 parent f5fe54f commit 1660a41

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

flang/lib/Optimizer/Transforms/AddDebugInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ bool AddDebugInfoPass::createCommonBlockGlobal(
148148
auto gvAttr = mlir::LLVM::DIGlobalVariableAttr::get(
149149
context, commonBlock, mlir::StringAttr::get(context, name),
150150
declOp.getUniqName(), fileAttr, line, diType,
151-
/*isLocalToUnit*/ true, /*isDefinition*/ true, /* alignInBits*/ 0);
151+
/*isLocalToUnit*/ false, /*isDefinition*/ true, /* alignInBits*/ 0);
152152
mlir::LLVM::DIExpressionAttr expr;
153153
if (*optint != 0) {
154154
llvm::SmallVector<mlir::LLVM::DIExpressionElemAttr> ops;

0 commit comments

Comments
 (0)