@@ -1960,17 +1960,17 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
1960
1960
for (auto [privDecl, mlirPrivVar, blockArg, llvmPrivateVarAlloc] :
1961
1961
llvm::zip_equal (privateDecls, mlirPrivateVars, privateBlockArgs,
1962
1962
taskStructMgr.getLLVMPrivateVarGEPs ())) {
1963
+ // To be handled inside the task.
1963
1964
if (!privDecl.readsFromMold ())
1964
- // to be handled inside the task
1965
1965
continue ;
1966
1966
assert (llvmPrivateVarAlloc &&
1967
1967
" reads from mold so shouldn't have been skipped" );
1968
1968
1969
1969
llvm::Expected<llvm::Value *> privateVarOrErr =
1970
1970
initPrivateVar (builder, moduleTranslation, privDecl, mlirPrivVar,
1971
1971
blockArg, llvmPrivateVarAlloc, initBlock);
1972
- if (auto err = privateVarOrErr. takeError () )
1973
- return handleError (std::move (err) , *taskOp.getOperation ());
1972
+ if (! privateVarOrErr)
1973
+ return handleError (privateVarOrErr , *taskOp.getOperation ());
1974
1974
1975
1975
llvm::IRBuilderBase::InsertPointGuard guard (builder);
1976
1976
builder.SetInsertPoint (builder.GetInsertBlock ()->getTerminator ());
@@ -2034,8 +2034,8 @@ convertOmpTaskOp(omp::TaskOp taskOp, llvm::IRBuilderBase &builder,
2034
2034
llvm::Expected<llvm::Value *> privateVarOrError =
2035
2035
initPrivateVar (builder, moduleTranslation, privDecl, mlirPrivVar,
2036
2036
blockArg, llvmPrivateVar, privInitBlock);
2037
- if (auto err = privateVarOrError. takeError () )
2038
- return err ;
2037
+ if (! privateVarOrError)
2038
+ return privateVarOrError. takeError () ;
2039
2039
moduleTranslation.mapValue (blockArg, privateVarOrError.get ());
2040
2040
llvmPrivateVars[i] = privateVarOrError.get ();
2041
2041
}
0 commit comments