address comments

matthias-springer · matthias-springer · commit 209d9226dec8 · 2025-01-03T14:35:25.000+01:00
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -260,7 +260,7 @@ ConversionValueMapping::lookupOrDefault(Value from,
   // If the desired values were found use them, otherwise default to the leaf
   // values.
   // Note: If `desiredTypes` is empty, this function always returns `current`.
-  return !desiredValue.empty() ? desiredValue : current;
+  return !desiredValue.empty() ? std::move(desiredValue) : std::move(current);
 }
 
 ValueVector ConversionValueMapping::lookupOrNull(Value from,

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ ConversionValueMapping::lookupOrDefault(Value from,`
`260`	`260`	`// If the desired values were found use them, otherwise default to the leaf`
`261`	`261`	`// values.`
`262`	`262`	// Note: If `desiredTypes` is empty, this function always returns `current`.
`263`		`- return !desiredValue.empty() ? desiredValue : current;`
	`263`	`+ return !desiredValue.empty() ? std::move(desiredValue) : std::move(current);`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`ValueVector ConversionValueMapping::lookupOrNull(Value from,`