Skip to content

Commit 248c534

Browse files
sedymrakMatej Košík
and
Matej Košík
authored
[lldb] Delete StepScope enum whose values are ignored. (#101981)
StepScope enum is a type whose values are passed around, but they are ultimately ignored. --------- Co-authored-by: Matej Košík <[email protected]>
1 parent ddb9869 commit 248c534

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

lldb/source/Commands/CommandObjectThread.cpp

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,6 @@ class CommandObjectThreadBacktrace : public CommandObjectIterateOverThreads {
247247
CommandOptions m_options;
248248
};
249249

250-
enum StepScope { eStepScopeSource, eStepScopeInstruction };
251-
252250
#define LLDB_OPTIONS_thread_step_scope
253251
#include "CommandOptions.inc"
254252

@@ -374,15 +372,13 @@ class CommandObjectThreadStepWithTypeAndScope : public CommandObjectParsed {
374372
CommandObjectThreadStepWithTypeAndScope(CommandInterpreter &interpreter,
375373
const char *name, const char *help,
376374
const char *syntax,
377-
StepType step_type,
378-
StepScope step_scope)
375+
StepType step_type)
379376
: CommandObjectParsed(interpreter, name, help, syntax,
380377
eCommandRequiresProcess | eCommandRequiresThread |
381378
eCommandTryTargetAPILock |
382379
eCommandProcessMustBeLaunched |
383380
eCommandProcessMustBePaused),
384-
m_step_type(step_type), m_step_scope(step_scope),
385-
m_class_options("scripted step") {
381+
m_step_type(step_type), m_class_options("scripted step") {
386382
AddSimpleArgumentList(eArgTypeThreadIndex, eArgRepeatOptional);
387383

388384
if (step_type == eStepTypeScripted) {
@@ -621,7 +617,6 @@ class CommandObjectThreadStepWithTypeAndScope : public CommandObjectParsed {
621617
}
622618

623619
StepType m_step_type;
624-
StepScope m_step_scope;
625620
ThreadStepScopeOptionGroup m_options;
626621
OptionGroupPythonClassWithDict m_class_options;
627622
OptionGroupOptions m_all_options;
@@ -2561,35 +2556,35 @@ CommandObjectMultiwordThread::CommandObjectMultiwordThread(
25612556
interpreter, "thread step-in",
25622557
"Source level single step, stepping into calls. Defaults "
25632558
"to current thread unless specified.",
2564-
nullptr, eStepTypeInto, eStepScopeSource)));
2559+
nullptr, eStepTypeInto)));
25652560

25662561
LoadSubCommand("step-out",
25672562
CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope(
25682563
interpreter, "thread step-out",
25692564
"Finish executing the current stack frame and stop after "
25702565
"returning. Defaults to current thread unless specified.",
2571-
nullptr, eStepTypeOut, eStepScopeSource)));
2566+
nullptr, eStepTypeOut)));
25722567

25732568
LoadSubCommand("step-over",
25742569
CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope(
25752570
interpreter, "thread step-over",
25762571
"Source level single step, stepping over calls. Defaults "
25772572
"to current thread unless specified.",
2578-
nullptr, eStepTypeOver, eStepScopeSource)));
2573+
nullptr, eStepTypeOver)));
25792574

25802575
LoadSubCommand("step-inst",
25812576
CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope(
25822577
interpreter, "thread step-inst",
25832578
"Instruction level single step, stepping into calls. "
25842579
"Defaults to current thread unless specified.",
2585-
nullptr, eStepTypeTrace, eStepScopeInstruction)));
2580+
nullptr, eStepTypeTrace)));
25862581

25872582
LoadSubCommand("step-inst-over",
25882583
CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope(
25892584
interpreter, "thread step-inst-over",
25902585
"Instruction level single step, stepping over calls. "
25912586
"Defaults to current thread unless specified.",
2592-
nullptr, eStepTypeTraceOver, eStepScopeInstruction)));
2587+
nullptr, eStepTypeTraceOver)));
25932588

25942589
LoadSubCommand(
25952590
"step-scripted",
@@ -2600,7 +2595,7 @@ CommandObjectMultiwordThread::CommandObjectMultiwordThread(
26002595
"that will be used to populate an SBStructuredData Dictionary, which "
26012596
"will be passed to the constructor of the class implementing the "
26022597
"scripted step. See the Python Reference for more details.",
2603-
nullptr, eStepTypeScripted, eStepScopeSource)));
2598+
nullptr, eStepTypeScripted)));
26042599

26052600
LoadSubCommand("plan", CommandObjectSP(new CommandObjectMultiwordThreadPlan(
26062601
interpreter)));

0 commit comments

Comments
 (0)