Skip to content

Commit 26a59bf

Browse files
committed
[TableGen] MacroFusionPredicatorEmitter - pass constant std::vector arguments by ArrayRef instead
Silence pass by value warnings Fixes #89210
1 parent 64cc3fa commit 26a59bf

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

llvm/utils/TableGen/MacroFusionPredicatorEmitter.cpp

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ class MacroFusionPredicatorEmitter {
5555
RecordKeeper &Records;
5656
CodeGenTarget Target;
5757

58-
void emitMacroFusionDecl(std::vector<Record *> Fusions, PredicateExpander &PE,
58+
void emitMacroFusionDecl(ArrayRef<Record *> Fusions, PredicateExpander &PE,
5959
raw_ostream &OS);
60-
void emitMacroFusionImpl(std::vector<Record *> Fusions, PredicateExpander &PE,
60+
void emitMacroFusionImpl(ArrayRef<Record *> Fusions, PredicateExpander &PE,
6161
raw_ostream &OS);
62-
void emitPredicates(std::vector<Record *> &FirstPredicate, bool IsCommutable,
62+
void emitPredicates(ArrayRef<Record *> FirstPredicate, bool IsCommutable,
6363
PredicateExpander &PE, raw_ostream &OS);
6464
void emitFirstPredicate(Record *SecondPredicate, bool IsCommutable,
6565
PredicateExpander &PE, raw_ostream &OS);
@@ -76,7 +76,7 @@ class MacroFusionPredicatorEmitter {
7676
} // End anonymous namespace.
7777

7878
void MacroFusionPredicatorEmitter::emitMacroFusionDecl(
79-
std::vector<Record *> Fusions, PredicateExpander &PE, raw_ostream &OS) {
79+
ArrayRef<Record *> Fusions, PredicateExpander &PE, raw_ostream &OS) {
8080
OS << "#ifdef GET_" << Target.getName() << "_MACRO_FUSION_PRED_DECL\n";
8181
OS << "#undef GET_" << Target.getName() << "_MACRO_FUSION_PRED_DECL\n\n";
8282
OS << "namespace llvm {\n";
@@ -93,7 +93,7 @@ void MacroFusionPredicatorEmitter::emitMacroFusionDecl(
9393
}
9494

9595
void MacroFusionPredicatorEmitter::emitMacroFusionImpl(
96-
std::vector<Record *> Fusions, PredicateExpander &PE, raw_ostream &OS) {
96+
ArrayRef<Record *> Fusions, PredicateExpander &PE, raw_ostream &OS) {
9797
OS << "#ifdef GET_" << Target.getName() << "_MACRO_FUSION_PRED_IMPL\n";
9898
OS << "#undef GET_" << Target.getName() << "_MACRO_FUSION_PRED_IMPL\n\n";
9999
OS << "namespace llvm {\n";
@@ -121,9 +121,10 @@ void MacroFusionPredicatorEmitter::emitMacroFusionImpl(
121121
OS << "\n#endif\n";
122122
}
123123

124-
void MacroFusionPredicatorEmitter::emitPredicates(
125-
std::vector<Record *> &Predicates, bool IsCommutable, PredicateExpander &PE,
126-
raw_ostream &OS) {
124+
void MacroFusionPredicatorEmitter::emitPredicates(ArrayRef<Record *> Predicates,
125+
bool IsCommutable,
126+
PredicateExpander &PE,
127+
raw_ostream &OS) {
127128
for (Record *Predicate : Predicates) {
128129
Record *Target = Predicate->getValueAsDef("Target");
129130
if (Target->getName() == "first_fusion_target")

0 commit comments

Comments
 (0)