Skip to content

Commit 27b53e9

Browse files
authored
llvm-reduce: Use takeName instead of setName when cloning functions (#133393)
1 parent 8dc64e9 commit 27b53e9

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,13 @@ static void extractArgumentsFromModule(Oracle &O, ReducerWorkItem &WorkItem) {
168168

169169
auto *ClonedFunc = CloneFunction(F, VMap);
170170
// In order to preserve function order, we move Clone after old Function
171+
ClonedFunc->takeName(F);
171172
ClonedFunc->removeFromParent();
172173
Program.getFunctionList().insertAfter(F->getIterator(), ClonedFunc);
173174

174175
replaceFunctionCalls(*F, *ClonedFunc, ArgIndexesToKeep);
175-
// Rename Cloned Function to Old's name
176-
std::string FName = std::string(F->getName());
177176
F->replaceAllUsesWith(ClonedFunc);
178177
F->eraseFromParent();
179-
ClonedFunc->setName(FName);
180178
}
181179
}
182180

llvm/tools/llvm-reduce/deltas/ReduceOperandsToArgs.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,9 @@ static void substituteOperandWithArgument(Function *OldF,
184184
// Replace all OldF uses with NewF.
185185
replaceFunctionCalls(OldF, NewF);
186186

187-
// Rename NewF to OldF's name.
188-
std::string FName = OldF->getName().str();
187+
NewF->takeName(OldF);
189188
OldF->replaceAllUsesWith(NewF);
190189
OldF->eraseFromParent();
191-
NewF->setName(FName);
192190
}
193191

194192
static void reduceOperandsToArgs(Oracle &O, ReducerWorkItem &WorkItem) {

0 commit comments

Comments
 (0)