Rename to getUnderlyingObjectAggressive

Author: nikic

llvm/include/llvm/Analysis/ValueTracking.h

@@ -736,10 +736,10 @@ inline Value *getUnderlyingObject(Value *V, unsigned MaxLookup = 6) {
   return const_cast<Value *>(getUnderlyingObject(VConst, MaxLookup));
 }
 
-/// Like getUnderlyingObject(), but will also look through phi/select nodes
-/// to establish a single underlying object.
-const Value *getUnderlyingObjectThroughPhisAndSelects(const Value *V,
-                                                      unsigned MaxLookup = 6);
+/// Like getUnderlyingObject(), but will try harder to find a single underlying
+/// object. In particular, this function also looks through selects and phis.
+const Value *getUnderlyingObjectAggressive(const Value *V,
+                                           unsigned MaxLookup = 6);
 
 /// This method is similar to getUnderlyingObject except that it can
 /// look through phi and select instructions and return multiple objects.

llvm/lib/Analysis/Loads.cpp

@@ -743,8 +743,8 @@ static bool isPointerAlwaysReplaceable(const Value *From, const Value *To,
   if (isa<Constant>(To) &&
       isDereferenceablePointer(To, Type::getInt8Ty(To->getContext()), DL))
     return true;
-  return getUnderlyingObjectThroughPhisAndSelects(From) ==
-         getUnderlyingObjectThroughPhisAndSelects(To);
+  return getUnderlyingObjectAggressive(From) ==
+         getUnderlyingObjectAggressive(To);
 }
 
 bool llvm::canReplacePointersInUseIfEqual(const Use &U, const Value *To,

llvm/lib/Analysis/ValueTracking.cpp

@@ -6609,9 +6609,8 @@ void llvm::getUnderlyingObjects(const Value *V,
   } while (!Worklist.empty());
 }
 
-const Value *
-llvm::getUnderlyingObjectThroughPhisAndSelects(const Value *V,
-                                               unsigned MaxLookup) {
+const Value *llvm::getUnderlyingObjectAggressive(const Value *V,
+                                                 unsigned MaxLookup) {
   const unsigned MaxVisited = 8;
 
   SmallPtrSet<const Value *, 8> Visited;