Skip to content

Commit 351f94d

Browse files
authored
[clang][NFC] resolve redundant predicates (#79701)
Fixes #79686
1 parent d033799 commit 351f94d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

clang/lib/Sema/SemaChecking.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17183,7 +17183,7 @@ class SequenceChecker : public ConstEvaluatedExprVisitor<SequenceChecker> {
1718317183
// evaluates to true.
1718417184
bool EvalResult = false;
1718517185
bool EvalOK = Eval.evaluate(BO->getLHS(), EvalResult);
17186-
bool ShouldVisitRHS = !EvalOK || (EvalOK && !EvalResult);
17186+
bool ShouldVisitRHS = !EvalOK || !EvalResult;
1718717187
if (ShouldVisitRHS) {
1718817188
Region = RHSRegion;
1718917189
Visit(BO->getRHS());
@@ -17215,7 +17215,7 @@ class SequenceChecker : public ConstEvaluatedExprVisitor<SequenceChecker> {
1721517215
// [...] the second operand is not evaluated if the first operand is false.
1721617216
bool EvalResult = false;
1721717217
bool EvalOK = Eval.evaluate(BO->getLHS(), EvalResult);
17218-
bool ShouldVisitRHS = !EvalOK || (EvalOK && EvalResult);
17218+
bool ShouldVisitRHS = !EvalOK || EvalResult;
1721917219
if (ShouldVisitRHS) {
1722017220
Region = RHSRegion;
1722117221
Visit(BO->getRHS());
@@ -17266,8 +17266,8 @@ class SequenceChecker : public ConstEvaluatedExprVisitor<SequenceChecker> {
1726617266
// evaluated. [...]
1726717267
bool EvalResult = false;
1726817268
bool EvalOK = Eval.evaluate(CO->getCond(), EvalResult);
17269-
bool ShouldVisitTrueExpr = !EvalOK || (EvalOK && EvalResult);
17270-
bool ShouldVisitFalseExpr = !EvalOK || (EvalOK && !EvalResult);
17269+
bool ShouldVisitTrueExpr = !EvalOK || EvalResult;
17270+
bool ShouldVisitFalseExpr = !EvalOK || !EvalResult;
1727117271
if (ShouldVisitTrueExpr) {
1727217272
Region = TrueRegion;
1727317273
Visit(CO->getTrueExpr());

0 commit comments

Comments
 (0)