Skip to content

Commit 3e7b720

Browse files
committed
Improve comments
1 parent ed4524b commit 3e7b720

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ class VPRecipeBuilder {
103103
VPBasicBlock *VPBB);
104104

105105
/// Makes Histogram count operations safe for vectorization, by emitting a
106-
/// Histogram LLVM Intrinsic before the BinOp (Add/Sub) that does the actual
107-
/// counting.
106+
/// llvm.experimental.vector.histogram.add intrinsic in place of the
107+
/// Load + Add|Sub + Store operations that perform the histogram in the
108+
/// original scalar loop.
108109
VPHistogramRecipe *tryToWidenHistogram(const HistogramInfo *HI,
109110
ArrayRef<VPValue *> Operands);
110111

llvm/test/Transforms/LoopVectorize/AArch64/sve2-histcnt.ll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ for.exit:
319319
ret void
320320
}
321321

322+
;; We don't support histograms with a update value that's not loop-invariant.
322323
define void @histogram_varying_increment(ptr noalias %buckets, ptr readonly %indices, ptr readonly %incvals, i64 %N) #0 {
323324
; CHECK-LABEL: define void @histogram_varying_increment(
324325
; CHECK-SAME: ptr noalias [[BUCKETS:%.*]], ptr readonly [[INDICES:%.*]], ptr readonly [[INCVALS:%.*]], i64 [[N:%.*]]) #[[ATTR0]] {

0 commit comments

Comments
 (0)